Page MenuHomeFreeBSD

ena: Properly unmap last socket chain in netmap
Needs ReviewPublic

Authored by osamaabb_amazon.com on Aug 20 2024, 8:47 AM.
Tags
None
Referenced Files
F171951267: D46365.diff
Mon, Sep 14, 9:09 PM
Unknown Object (File)
Mon, Sep 14, 1:02 PM
Unknown Object (File)
Sun, Sep 6, 2:14 AM
Unknown Object (File)
Fri, Sep 4, 8:47 PM
Unknown Object (File)
Wed, Aug 19, 4:28 AM
Unknown Object (File)
Aug 12 2026, 8:23 PM
Unknown Object (File)
Aug 10 2026, 7:27 AM
Unknown Object (File)
Aug 7 2026, 6:44 PM
Subscribers

Details

Reviewers
cperciva
Summary

In case ena_com_prepare_tx() fails within the netmap tx flow,
the driver will unmap the last socket chain.
Currently, the driver unmaps the wrong socket within
ena_netmap_unmap_last_socket_chain().

Illustration of the flow:

1- ena_netmap_tx_frames()
2- ena_netmap_tx_frame()
3- ena_netmap_tx_map_slots()
3.1- Map slot
3.2- Advance to the next socket
4- ena_com_prepare_tx()
4.1- ena_com_prepare_tx() fails
5- ena_netmap_unmap_last_socket_chain()

In step 5, where the driver unmaps the socket, the netmap
index already points at the next entry, meaning we're unmapping the
wrong socket in case ena_com_prepare_tx() fails.
In order to fix that, the driver should first update the netmap index to
point at the previous entry and only then update the socket parameters.

Approved by: cperciva
MFC after: 2 weeks
Sponsored by: Amazon, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 59094
Build 55981: arc lint + arc unit