Details
- Reviewers
bapt mat - Commits
- rP404329: - Update to 2.6.0.0
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| games/asc/Makefile | ||
|---|---|---|
| 16 ↗ | (On Diff #11447) | unneeded change. |
| 23–24 ↗ | (On Diff #11447) | no need to change the order here. |
| 25 ↗ | (On Diff #11447) | Unneeded change. |
| 29 ↗ | (On Diff #11447) | no real need to move that line either. |
| 49–50 ↗ | (On Diff #11447) | use ${DATADIR} here |
| 65 ↗ | (On Diff #11447) | Why not use ${CP} here ? |
| 73–74 ↗ | (On Diff #11447) | no need to change the order of the lines. |
| games/asc/Makefile | ||
|---|---|---|
| 49–50 ↗ | (On Diff #11447) | Do you mind to explain this to me. We used always %%DATADIR%% for PLIST_FILES, https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.html 6.14.3. Best Practices, Suggest also to use %%FOO%%. |
| games/asc/Makefile | ||
|---|---|---|
| 49–50 ↗ | (On Diff #11447) | The only reason there are %%FOO%% thingies in the pkg-plist files is because we need a way to represent the content of ${FOO} in there. When you are in the Makefile, you already have access to ${FOO} there is no need to not use it directly. I'll change the porter's handbook bit about java best practices, I don't use java so I never went over that section. |