ena: Add unlikely to error checks
Needs ReviewPublic
Actions

Authored by osamaabb_amazon.com on Aug 20 2024, 8:46 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Jun 28, 11:54 PM

	Unknown Object (File)
	Sun, Jun 28, 6:22 PM

	Unknown Object (File)
	Jun 1 2026, 3:55 PM

	Unknown Object (File)
	Jun 1 2026, 1:30 AM

	Unknown Object (File)
	May 30 2026, 8:06 AM

	Unknown Object (File)
	Apr 8 2026, 3:22 PM

	Unknown Object (File)
	Apr 6 2026, 11:40 AM

	Unknown Object (File)
	Mar 3 2026, 3:57 AM

View All 51 Files

Subscribers

imp

Details

Reviewers

cperciva

Summary

The unlikely mechanism is used to reduce pipe flush,
caused by a wrong branch prediction.
Moreover, it increases readability by wrapping unexpected errors.
This commit adds unlikely to error checks that are unlikely to happen.

Approved by: cperciva
MFC after: 2 weeks
Sponsored by: Amazon, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 59074
Build 55961: arc lint + arc unit

Event Timeline

osamaabb_amazon.com created this revision.Aug 20 2024, 8:46 AM

Herald added a subscriber: imp. · View Herald TranscriptAug 20 2024, 8:46 AM

osamaabb_amazon.com requested review of this revision.Aug 20 2024, 8:46 AM

Harbormaster completed remote builds in B59074: Diff 142204.Aug 20 2024, 8:46 AM

Revision Contents
Changeset List

Path

Size

sys/

contrib/

ena-com/

ena_com.c

60 lines

ena_eth_com.c

2 lines

Diff 142204

View Options

sys/contrib/ena-com/ena_com.c