ena: Add unlikely to error checks
Needs ReviewPublic
Actions

Authored by osamaabb_amazon.com on Aug 20 2024, 8:46 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Aug 14, 5:25 PM

	Unknown Object (File)
	Wed, Aug 12, 4:53 PM

	Unknown Object (File)
	Sun, Aug 9, 12:24 PM

	Unknown Object (File)
	Sat, Aug 8, 2:13 AM

	Unknown Object (File)
	Wed, Aug 5, 2:57 AM

	Unknown Object (File)
	Tue, Aug 4, 8:40 AM

	Unknown Object (File)
	Tue, Jul 28, 1:40 AM

	Unknown Object (File)
	Mon, Jul 27, 3:59 PM

View All 62 Files

Subscribers

imp

Details

Reviewers

cperciva

Summary

The unlikely mechanism is used to reduce pipe flush,
caused by a wrong branch prediction.
Moreover, it increases readability by wrapping unexpected errors.
This commit adds unlikely to error checks that are unlikely to happen.

Approved by: cperciva
MFC after: 2 weeks
Sponsored by: Amazon, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 59074
Build 55961: arc lint + arc unit

Event Timeline

osamaabb_amazon.com created this revision.Aug 20 2024, 8:46 AM

Herald added a subscriber: imp. · View Herald TranscriptAug 20 2024, 8:46 AM

osamaabb_amazon.com requested review of this revision.Aug 20 2024, 8:46 AM

Harbormaster completed remote builds in B59074: Diff 142204.Aug 20 2024, 8:46 AM

Revision Contents
Changeset List

Path

Size

sys/

contrib/

ena-com/

ena_com.c

60 lines

ena_eth_com.c

2 lines

Diff 142204

View Options

sys/contrib/ena-com/ena_com.c