Page MenuHomeFreeBSD

ena: Fix crash when interrupt arrives after admin command timeout
Needs ReviewPublic

Authored by osamaabb_amazon.com on Aug 20 2024, 8:46 AM.
Tags
None
Referenced Files
F175192893: D46344.diff
Fri, Oct 9, 12:13 AM
Unknown Object (File)
Thu, Oct 1, 4:24 AM
Unknown Object (File)
Fri, Sep 18, 10:41 PM
Unknown Object (File)
Mon, Sep 14, 6:34 PM
Unknown Object (File)
Fri, Sep 11, 3:47 AM
Unknown Object (File)
Sep 7 2026, 4:34 PM
Unknown Object (File)
Aug 25 2026, 7:36 AM
Unknown Object (File)
Aug 12 2026, 11:24 PM
Subscribers

Details

Reviewers
cperciva
Summary

Bug description:
When invoking an admin command, in interrupt mode, if the interrupt
is received after timeout and also after the calling function finished
running, the response will be written into a memory that is no longer
valid.

We fix this by applying the following:

  1. Verifying that comp_ctx is occupied during the interrupt handler, otherwise it doesn't make sense to update its fields.
  2. Set user_cqe to NULL when the admin command times out. When the interrupt handler is later invoked, it will check if it is NULL and will not use it.

Approved by: cperciva
MFC after: 2 weeks
Sponsored by: Amazon, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 59073
Build 55960: arc lint + arc unit