Page MenuHomeFreeBSD

ena: Fix crash when interrupt arrives after admin command timeout
Needs ReviewPublic

Authored by osamaabb_amazon.com on Aug 20 2024, 8:46 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 7, 1:19 PM
Unknown Object (File)
Fri, Sep 26, 11:59 AM
Unknown Object (File)
Wed, Sep 24, 11:37 PM
Unknown Object (File)
Thu, Sep 18, 10:19 PM
Unknown Object (File)
Sep 9 2025, 10:54 PM
Unknown Object (File)
Aug 29 2025, 7:36 PM
Unknown Object (File)
Jul 15 2025, 11:57 PM
Unknown Object (File)
Jul 5 2025, 9:05 AM
Subscribers

Details

Reviewers
cperciva
Summary

Bug description:
When invoking an admin command, in interrupt mode, if the interrupt
is received after timeout and also after the calling function finished
running, the response will be written into a memory that is no longer
valid.

We fix this by applying the following:

  1. Verifying that comp_ctx is occupied during the interrupt handler, otherwise it doesn't make sense to update its fields.
  2. Set user_cqe to NULL when the admin command times out. When the interrupt handler is later invoked, it will check if it is NULL and will not use it.

Approved by: cperciva
MFC after: 2 weeks
Sponsored by: Amazon, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 59073
Build 55960: arc lint + arc unit