Page MenuHomeFreeBSD

ena: PHC activation check point
Needs ReviewPublic

Authored by osamaabb_amazon.com on Aug 20 2024, 8:46 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Sep 27, 2:31 PM
Unknown Object (File)
Aug 30 2025, 11:24 AM
Unknown Object (File)
Aug 29 2025, 8:27 PM
Unknown Object (File)
Aug 19 2025, 8:57 AM
Unknown Object (File)
Aug 15 2025, 4:22 AM
Unknown Object (File)
Aug 2 2025, 8:43 AM
Unknown Object (File)
Jul 28 2025, 8:37 AM
Unknown Object (File)
Jul 26 2025, 5:16 PM
Subscribers

Details

Reviewers
cperciva
Summary

Following this change, PHC can be activated on supported devices.
Driver and device will each hold its own max supported PHC version.
Initial supported PHC version including all changes to this check point
is ENA_ADMIN_PHC_FEATURE_VERSION_0,
all future PHC versions should always be backward compatible.

PHC mutual support is decided in the following steps:

  1. Driver publishes PHC support
  2. Device publishes PHC support
  3. Driver publishes supported PHC version
  4. Device publishes supported PHC version and settings
  5. Driver enables PHC

    DRIVER DEVICE | (1) | | Driver sends ENA_ADMIN_SET_FEATURE | | - Set feature ID ENA_ADMIN_HOST_ATTR_CONFIG | | - Enable bit ENA_ADMIN_HOST_INFO_PHC_MASK | | ------------------------------------------------> | | (2) | | Driver sends ENA_ADMIN_GET_FEATURE | | - Set feature ID ENA_ADMIN_DEVICE_ATTRIBUTES | | ------------------------------------------------> | | Device responds to ENA_ADMIN_GET_FEATURE | | - Enable bit ENA_ADMIN_PHC_CONFIG | | <------------------------------------------------ | | (3) | | Driver sends ENA_ADMIN_GET_FEATURE | | - Set feature ID ENA_ADMIN_PHC_CONFIG | | - Set PHC version ENA_ADMIN_PHC_FEATURE_VERSION_0 | | ------------------------------------------------> | | (4) | | Device responds to ENA_ADMIN_GET_FEATURE | | - Set PHC version | | - Set doorbel offset | | - Set timeouts | | <------------------------------------------------ | | (5) | | Driver sends ENA_ADMIN_SET_FEATURE | | - Set feature ID ENA_ADMIN_PHC_CONFIG | | - Set output address/length | | ------------------------------------------------> |

Approved by: cperciva
MFC after: 2 weeks
Sponsored by: Amazon, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 59072
Build 55959: arc lint + arc unit