Rename "More Events", "More Media" and "More News" to just "More"
AcceptedPublic
Actions

Authored by mail_janek.ooo on Sun, Jun 30, 3:02 PM.

Details

Reviewers

Summary

The naming of these buttons is inconsistent - two of them just say "More" and three say "More X". Because the section tittles are very close and mention "X", I believe just "More" is better. This also allows the removal of some i18n entries, including one that was inconsistent (missing 1 of 4 entries).

Before	After

(note that the before/after includes all changes from this stack)

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 58426
Build 55314: arc lint + arc unit

Event Timeline

mail_janek.ooo requested review of this revision.Sun, Jun 30, 3:02 PM

mail_janek.ooo created this revision.

mail_janek.ooo added a parent revision: Restricted Differential Revision.

mail_janek.ooo added a child revision: D45810: Rename ico_rss.png files to be compatible with D45806.

Harbormaster completed remote builds in B58426: Diff 140400.Sun, Jun 30, 3:02 PM

mail_janek.ooo edited the summary of this revision. (Show Details)Sun, Jun 30, 3:15 PM

mail_janek.ooo retitled this revision from Rename all button names to "More" from "More Events", "More Media" etc. Remove i18n entries that are orphaned by this to Rename "More Events", "More Media" and "More News" to just "More".

mail_janek.ooo mentioned this in D45810: Rename ico_rss.png files to be compatible with D45806.Sun, Jun 30, 3:17 PM

LGTM!

It looks way cleaner now and I think that just using one "more" makes a lot of sense.

This revision is now accepted and ready to land.Mon, Jul 1, 9:00 AM

mail_janek.ooo added a child revision: D45811: Add red arrows to the "More" buttons at the bottom of the news/events/press sections.Mon, Jul 1, 9:17 AM

mail_janek.ooo removed a child revision: D45810: Rename ico_rss.png files to be compatible with D45806.