Differential D45027

[draft] run clang-format over sys/dev/sound
Needs ReviewPublic
Actions

Authored by emaste on Apr 30 2024, 4:53 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Nov 10, 6:38 AM

	Unknown Object (File)
	Mon, Nov 10, 6:38 AM

	Unknown Object (File)
	Wed, Oct 29, 12:06 PM

	Unknown Object (File)
	Wed, Oct 29, 12:05 PM

	Unknown Object (File)
	Oct 12 2025, 3:25 AM

	Unknown Object (File)
	Oct 10 2025, 12:58 PM

	Unknown Object (File)
	Oct 7 2025, 12:07 PM

	Unknown Object (File)
	Sep 10 2025, 11:36 AM

View All 61 Files

Subscribers

None

This revision needs review, but there are no reviewers specified.

Details

Reviewers: None

Summary

Continuing experiments with clang-format (D30260, D26340), let me try running it over a reasonably large collection of kernel code. This review exists just to examine the sorts of things clang-format does, and identify potential changes we might want to have done upstream.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste requested review of this revision.Apr 30 2024, 4:53 PM

emaste created this revision.

emaste added inline comments.Apr 30 2024, 5:42 PM

sys/dev/sound/fdt/audio_soc.c
28	.clang-format has include file ordering rules, and puts "opt_.h" first. style(9) does not mention opt_.h at all
190	Undesired extra space fixed by D29870
276–277	this is unfortunate
377–379	this is a mess
398–399	extra 2nd level indent
sys/dev/sound/pci/allegro_code.h
1403	apparently clang-format uses a trailing comma as an indicator that array initialization should be done one-per-line

Revision Contents
Changeset List

Path

Size

sys/

dev/

sound/

4 lines

6 lines

fdt/

55 lines

195 lines

26 lines

simple_amplifier.c

43 lines

isa/

223 lines

macio/

14 lines

129 lines

188 lines

350 lines

334 lines

142 lines

379 lines

321 lines

midi/

26 lines

380 lines

141 lines

5 lines

92 lines

40 lines

563 lines

pci/

1500 lines

1239 lines

112 lines

256 lines

282 lines

265 lines

474 lines

318 lines

328 lines

1216 lines

6227 lines

289 lines

88 lines

241 lines

2209 lines

8 lines

736 lines

77 lines

588 lines

233 lines

1937 lines

1188 lines

657 lines

1189 lines

209 lines

3355 lines

316 lines

467 lines

571 lines

hda/

2309 lines

235 lines

2742 lines

222 lines

1597 lines

729 lines

212 lines

359 lines

849 lines

130 lines

pin_patch_realtek.h

1753 lines

153 lines

315 lines

168 lines

65 lines

496 lines

797 lines

neomagic-coeff.h

8833 lines

6 lines

232 lines

272 lines

68 lines

216 lines

122 lines

416 lines

241 lines

360 lines

75 lines

231 lines

302 lines

495 lines

pcm/

113 lines

526 lines

12 lines

33 lines

23 lines

90 lines

384 lines

366 lines

807 lines

64 lines

142 lines

321 lines

332 lines

feeder_format.c

79 lines

feeder_matrix.c

284 lines

140 lines

906 lines

feeder_volume.c

113 lines

309 lines

176 lines

263 lines

119 lines

24 lines

156 lines

619 lines

243 lines

749 lines

194 lines

33 lines

122 lines

10 lines

31 lines

usb/

61 lines

1688 lines

30 lines

1121 lines

2 lines

Diff 137899

sys/dev/sound/chip.h

Loading...

sys/dev/sound/driver.c

Loading...

sys/dev/sound/fdt/audio_dai.h

Loading...

sys/dev/sound/fdt/audio_soc.c

Loading...

sys/dev/sound/fdt/dummy_codec.c

Loading...

sys/dev/sound/fdt/simple_amplifier.c

Loading...

sys/dev/sound/isa/sb.h

Loading...

sys/dev/sound/macio/aoa.h

Loading...

sys/dev/sound/macio/aoa.c

Loading...

sys/dev/sound/macio/davbus.c

Loading...

sys/dev/sound/macio/davbusreg.h

Loading...

sys/dev/sound/macio/i2s.c

Loading...

sys/dev/sound/macio/onyx.c

Loading...

sys/dev/sound/macio/snapper.c

Loading...

sys/dev/sound/macio/tumbler.c

Loading...

sys/dev/sound/midi/midi.h

Loading...

sys/dev/sound/midi/midi.c

Loading...

sys/dev/sound/midi/midiq.h

Loading...

sys/dev/sound/midi/mpu401.h

Loading...

sys/dev/sound/midi/mpu401.c

Loading...

sys/dev/sound/midi/sequencer.h

Loading...

sys/dev/sound/midi/sequencer.c

Loading...

sys/dev/sound/pci/allegro_code.h

Loading...

sys/dev/sound/pci/allegro_reg.h

Loading...

sys/dev/sound/pci/als4000.h

Loading...

sys/dev/sound/pci/als4000.c

Loading...

sys/dev/sound/pci/atiixp.h

Loading...

sys/dev/sound/pci/atiixp.c

Loading...

sys/dev/sound/pci/cmi.c

Loading...

sys/dev/sound/pci/cmireg.h

Loading...

sys/dev/sound/pci/cs4281.h

Loading...

sys/dev/sound/pci/cs4281.c

Loading...

sys/dev/sound/pci/cs461x_dsp.h

Loading...

sys/dev/sound/pci/csa.c

Loading...

sys/dev/sound/pci/csamidi.c

Loading...

sys/dev/sound/pci/csapcm.c

Loading...

sys/dev/sound/pci/csareg.h

Loading...

sys/dev/sound/pci/csavar.h

Loading...

sys/dev/sound/pci/emu10k1.c

Loading...

sys/dev/sound/pci/emu10kx-midi.c

Loading...

sys/dev/sound/pci/emu10kx-pcm.c

Loading...

sys/dev/sound/pci/emu10kx.h

Loading...

sys/dev/sound/pci/emu10kx.c

Loading...

sys/dev/sound/pci/emuxkireg.h

Loading...

sys/dev/sound/pci/envy24.h

Loading...

sys/dev/sound/pci/envy24.c

Loading...

sys/dev/sound/pci/envy24ht.h

Loading...

sys/dev/sound/pci/envy24ht.c

Loading...

sys/dev/sound/pci/es137x.h

Loading...

sys/dev/sound/pci/es137x.c

Loading...

sys/dev/sound/pci/fm801.c

Loading...

sys/dev/sound/pci/hda/hda_reg.h

Loading...

sys/dev/sound/pci/hda/hdaa.h

Loading...

sys/dev/sound/pci/hda/hdaa.c

Loading...

sys/dev/sound/pci/hda/hdaa_patches.c

Loading...

sys/dev/sound/pci/hda/hdac.h

Loading...

sys/dev/sound/pci/hda/hdac.c

Loading...

sys/dev/sound/pci/hda/hdac_private.h

Loading...

sys/dev/sound/pci/hda/hdac_reg.h

Loading...

sys/dev/sound/pci/hda/hdacc.c

Loading...

sys/dev/sound/pci/hda/pin_patch.h

Loading...

sys/dev/sound/pci/hda/pin_patch_realtek.h

Loading...

sys/dev/sound/pci/hdspe-pcm.c

Loading...

sys/dev/sound/pci/hdspe.h

Loading...

sys/dev/sound/pci/hdspe.c

Loading...

sys/dev/sound/pci/ich.h

Loading...

sys/dev/sound/pci/ich.c

Loading...

sys/dev/sound/pci/maestro3.c

Loading...

sys/dev/sound/pci/neomagic-coeff.h

Loading...

sys/dev/sound/pci/neomagic.h

Loading...

sys/dev/sound/pci/neomagic.c

Loading...

sys/dev/sound/pci/solo.c

Loading...

sys/dev/sound/pci/spicds.h

Loading...

sys/dev/sound/pci/spicds.c

Loading...

sys/dev/sound/pci/t4dwave.h

Loading...

sys/dev/sound/pci/t4dwave.c

Loading...

sys/dev/sound/pci/via8233.h

Loading...

sys/dev/sound/pci/via8233.c

Loading...

sys/dev/sound/pci/via82c686.h

Loading...

sys/dev/sound/pci/via82c686.c

Loading...

sys/dev/sound/pci/vibes.h

Loading...

sys/dev/sound/pci/vibes.c

Loading...

sys/dev/sound/pcm/ac97.h

Loading...

sys/dev/sound/pcm/ac97.c

Loading...

sys/dev/sound/pcm/ac97_patch.h

Loading...

sys/dev/sound/pcm/ac97_patch.c

Loading...

sys/dev/sound/pcm/buffer.h

Loading...

sys/dev/sound/pcm/buffer.c

Loading...

sys/dev/sound/pcm/channel.h

Loading...

sys/dev/sound/pcm/channel.c

Loading...

sys/dev/sound/pcm/dsp.c

Loading...

sys/dev/sound/pcm/feeder.h

Loading...

sys/dev/sound/pcm/feeder.c

Loading...

sys/dev/sound/pcm/feeder_chain.c

Loading...

sys/dev/sound/pcm/feeder_eq.c

Loading...

sys/dev/sound/pcm/feeder_format.c

Loading...

sys/dev/sound/pcm/feeder_matrix.c

Loading...

sys/dev/sound/pcm/feeder_mixer.c

Loading...

sys/dev/sound/pcm/feeder_rate.c

Loading...

sys/dev/sound/pcm/feeder_volume.c

Loading...

sys/dev/sound/pcm/g711.h

Loading...

sys/dev/sound/pcm/intpcm.h

Loading...

sys/dev/sound/pcm/matrix.h

Loading...

sys/dev/sound/pcm/matrix_map.h

Loading...

sys/dev/sound/pcm/mixer.h

Loading...

sys/dev/sound/pcm/mixer.c

Loading...

sys/dev/sound/pcm/pcm.h

Loading...

sys/dev/sound/pcm/sndstat.c

Loading...

sys/dev/sound/pcm/sound.h

Loading...

sys/dev/sound/pcm/sound.c

Loading...

sys/dev/sound/pcm/vchan.h

Loading...

sys/dev/sound/pcm/vchan.c

Loading...

sys/dev/sound/unit.h

Loading...

sys/dev/sound/unit.c

Loading...

sys/dev/sound/usb/uaudio.h

Loading...

sys/dev/sound/usb/uaudio.c

Loading...

sys/dev/sound/usb/uaudio_pcm.c

Loading...

sys/dev/sound/usb/uaudioreg.h

Loading...

sys/dev/sound/version.h

Loading...