Unmuting console boot messages for some scenarios

[nkumarababu_gmail.com]

Summary

Halt and a few error scenarios would need console boot messages
to be unmuted, if they are muted.

[imp]

Any reason to not always set cn_mute = 0 unconditionally?

[nkumarababu_gmail.com]

cn_mute should be 0, unless boot messages are explicitly muted. If boot messages are muted, this change is to unmute, to help restart in cases like "halt".

[nkumarababu_gmail.com]

More applicable with this change : https://reviews.freebsd.org/D45032

[nkumarababu_gmail.com]

Any further questions/inputs on this change ?

[imp]

I'm not sure I understood the response, and failed to say so at the time. My apologies for the oversight. I must have seen it and then failed to tag it for followup on my phone.

Originally, I was trying to ask something like: since cn_mute will only ever be set to 1 when RB_MUTEMSGS is set in boothowto, why is a check for that flag needed?

However, that was based on a sloppy reading of when cn_mute can be set to one. It can often be set by boot tuneable or when RB_MUTE is set. I'd not considered those cases, but even considering them, I don't understand the response, so I have some new questions to help me understand...

Why do you only want to unmute when RB_MUTEMSGS is set? Wouldn't you want to unconditionally unmute for these cases? When asking a question and when reporting an error?

Thanks for the followup. Again, sorry not replying sooner.

[imp]

I hit submit too quickly. I'd like to add "We set it unconditionally in panic, so why not here too?"