Page MenuHomeFreeBSD

efi: Add macros for building an EFI GUID
Needs ReviewPublic

Authored by stevek on Apr 3 2024, 8:29 PM.
Tags
None
Referenced Files
F84754990: D44622.id.diff
Tue, May 28, 2:46 AM
Unknown Object (File)
Fri, May 17, 3:14 PM
Unknown Object (File)
Apr 26 2024, 4:44 AM
Unknown Object (File)
Apr 11 2024, 10:32 PM
Unknown Object (File)
Apr 8 2024, 8:44 PM
Unknown Object (File)
Apr 5 2024, 7:45 PM
Subscribers
None

Details

Reviewers
imp
Summary

EFI_GUID() macro can be used to build an EFI GUID.
Define EFI_GLOBAL_GUID for the EFI global variable space.

Add typedef for EFI GUID (efi_guid_t)

Obtained from: Juniper Networks, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 56899
Build 53787: arc lint + arc unit

Event Timeline

stevek requested review of this revision.Apr 3 2024, 8:29 PM
stevek created this revision.
sys/sys/efi.h
58

Why not do this like all the others?

Also, big endian efi isn't a thing. Too much is implicitly LE

sys/sys/efi.h
58

IIRC, the EFI_GUID() macro is in the spec (or maybe it was EDK2 reference?) and that was why it was being used.

Would you prefer changing the existing things to use the macro or change this global GUID setting to not use the macro?