Page MenuHomeFreeBSD

Fixup include protections for building on mips64 with clang
ClosedPublic

Authored by lidl on Dec 9 2015, 3:50 PM.

Details

Summary

Apparently clang on mips64 defines "mips", which triggers an
include of a non-existant header. Another way to fix this
would be to remove the entire block of includes, since RISC/os
has been obsolete for a decade.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

lidl updated this revision to Diff 10967.Dec 9 2015, 3:50 PM
lidl retitled this revision from to Fixup include protections for building on mips64 with clang.
lidl updated this object.
lidl edited the test plan for this revision. (Show Details)
lidl added reviewers: rpaulo, sbruno.
sbruno accepted this revision.Dec 9 2015, 4:32 PM
sbruno edited edge metadata.

Looks good here.

This revision is now accepted and ready to land.Dec 9 2015, 4:32 PM
imp added inline comments.Dec 9 2015, 4:35 PM
contrib/top/loadavg.h
22 ↗(On Diff #10967)

I'm good with this. Also acceptable, imho, would be && defined(BSD) since we include sys/param.h in an earlier include.
Have you checked upstream? Perhaps it is fixed there?

lidl added inline comments.Dec 9 2015, 5:54 PM
contrib/top/loadavg.h
22 ↗(On Diff #10967)

The last upstream release (http://sourceforge.net/projects/unixtop/) was made in 2008.

Downloading that tarball and looking, the only difference in the loadavg.h file is a check for ibm032 (i.e. IBM PC/RT).

rpaulo accepted this revision.Dec 11 2015, 5:21 AM
rpaulo edited edge metadata.
This revision was automatically updated to reflect the committed changes.