This adds a patch to remove an extra version check around the Linux
LIST macros which has caused some compilation failures.
Details
Diff Detail
- Repository
- R11 FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
I don't think so? The 550 build has been broken because of this so no actual version has been "released" for nvidia-drm-510-kmod with 550, so it doesn't seem like bumping the revision would do anything? I can if needed though
On FreeBSD 13 this results in
In file included from nvidia-drm.c:23: In file included from ./nvidia-drm.h:26: In file included from ./nvidia-drm-conftest.h:102: ../common/inc/nv-mm.h:110:31: error: too many arguments to function call, expected 5, have 8 force, pages, NULL); ^~~~~~~~~~~~~~~~~~
This is actually a problem with 13.2: the get_user_pages function incorrectly defines the gup_flags argument as an "int" instead of as an "unsigned int". 13.3 and onward have this problem fixed.
Not sure the best way to handle this? I guess we could have an extra patch applied in the "<= 13.2" case that makes the get_user_pages in conftest.sh use an "int gup_flags" so that it matches? That would work but do we normally do gross-ish workarounds like that now that 13.3 is out?
13.2 is officially supported for the 13.3-RELEASE date + 3 months. So, it'd be good if you can fix the port to work on 13.2
If this is too much work, then we should place a conditional IGNORE= not supported on 13.2 knob in the ports Makefile.