Page MenuHomeFreeBSD

devel/openocd: Overhaul Makefile
ClosedPublic

Authored by jbo on Feb 24 2024, 8:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 17, 8:01 PM
Unknown Object (File)
Sun, Apr 14, 3:35 PM
Unknown Object (File)
Sat, Apr 13, 11:24 AM
Unknown Object (File)
Tue, Apr 9, 4:46 PM
Unknown Object (File)
Mon, Apr 8, 6:18 PM
Unknown Object (File)
Mon, Apr 8, 5:20 PM
Unknown Object (File)
Tue, Apr 2, 7:56 AM
Unknown Object (File)
Mon, Apr 1, 10:16 PM
Subscribers

Details

Summary

Major overhaul after taking over maintainership.

Background information to understand some of the changes: OpenOCD is a piece
of software which talks to chip programming/debugging adapters (hardware).
Different adapters use different interface to connect to the host OS (such as
USB).

  • Previously, the port provided one option per upstream supported adapter. This was changed to a "per-interface" option as we mostly care about handling dependencies rather than sequezing out every single byte of the resulting binary size.
  • Upstream's doxygen documentation has been removed from this port as this particular piece of documentation is almost entirely only relevant when doing development work on upstream code. The man page is still being installed (unchanged).
  • Adding more options previously not exposed by the port.
  • The various VERBOSE_ options are not combined into a single option as the amount of information would be overwhelming and not necessarily helpful.
  • A local patch to resolve the broken Aarch64 build would be possible but up- stream has removed the offending piece of code since their last release. As such, this patch would be obsolete on the next release and existing users of this port are already "used" to this restriction.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jbo requested review of this revision.Feb 24 2024, 8:03 PM
jbo created this revision.

A note regarding the order/sorting of _CONFIGURE_ENABLE=: These are intentionally left in a non-alphabetic order to match the order of upstream's configure.ac. This makes port updates less of a hassle as matching differently sorted lists is a pain.

Two questions regarding JIMTCL_EXTERNAL_CFLAGS=:

  • Why is manually setting -I${LOCALBASE}/include necessary? Without this, the compiler fails to find the #include <jim.h> header. Wouldn't LIB_DEPENDS take care of this?
  • Would manual setting -L${LOCALBASE}/lib also be necessary?
jbo added a subscriber: diizzy.

Improvements as suggested by @diizzy.

Fix variable order (make portclippy happy).

devel/openocd/Makefile
17

If you already have the patch working and tested, I'd opt for including it as aarch64 is tier-1 in base. But if not (additional work needed?), that's fine as well.

25–26

Is it possible to patch&upstream that instead?
Or, if not, to be more specific (-Wno-error=foo)?

jbo marked 2 inline comments as done.

Improve handling of -Wno-error.

This revision is now accepted and ready to land.Feb 27 2024, 2:55 PM
This revision was automatically updated to reflect the committed changes.