Fix Tx queues to USB endpoints mapping and merge two dma_init functions into one
ClosedPublic
Actions

Authored by kevlo on Dec 4 2015, 3:23 PM.

Details

Reviewers

avos
adrian

Commits

rS291902: - Fix Tx queues to USB endpoints mapping

Summary

Fix Tx queues to USB endpoints mapping
Merge urtwn_r92c_dma_init() and urtwn_r88e_dma_init() into one

Tested on RTL8188CU, RTL8192CU, and RTL8188EU.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kevlo updated this revision to Diff 10743.Dec 4 2015, 3:23 PM

kevlo retitled this revision from to Fix Tx queues to USB endpoints mapping and merge two dma_init functions into one .

kevlo updated this object.

kevlo edited the test plan for this revision. (Show Details)

kevlo added reviewers: adrian, avos.

Looks fine to me; which other chipsets need testing?

In D4381#92266, @adrian wrote:

Looks fine to me; which other chipsets need testing?

RTL8188RU. All chipsets which the urtwn(4) supports (including
upcoming RTL8192EU and RTL8723BU chipsets) are use the same logic.

avos added inline comments.Dec 5 2015, 2:13 PM

sys/dev/usb/wlan/if_urtwn.c
34 ↗	(On Diff #10743)	where it's used?

kevlo added inline comments.Dec 5 2015, 2:53 PM

sys/dev/usb/wlan/if_urtwn.c
34 ↗	(On Diff #10743)	The header usb_device.h needs to include sys/condvar.h to define struct cv.

Works fine for me.

This revision is now accepted and ready to land.Dec 5 2015, 3:22 PM

Closed by commit rS291902: - Fix Tx queues to USB endpoints mapping (authored by kevlo). · Explain WhyDec 6 2015, 2:08 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

usb/

wlan/

if_urtwn.c

219 lines

if_urtwnvar.h

2 lines

Diff 10821

View Options

head/sys/dev/usb/wlan/if_urtwn.c