targ: Handle errors from suword()
ClosedPublic
Actions

Authored by markj on Dec 26 2023, 11:57 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Apr 29 2026, 4:35 AM

	Unknown Object (File)
	Apr 28 2026, 3:00 AM

	Unknown Object (File)
	Apr 27 2026, 5:46 PM

	Unknown Object (File)
	Apr 20 2026, 5:06 AM

	Unknown Object (File)
	Apr 19 2026, 5:58 PM

	Unknown Object (File)
	Apr 18 2026, 4:28 PM

	Unknown Object (File)
	Apr 11 2026, 3:20 PM

	Unknown Object (File)
	Apr 9 2026, 2:07 AM

View All Files

Subscribers

imp

Details

Reviewers

None

Group Reviewers

cam

Commits

rG185634d86d96: targ: Handle errors from suword()
rG904cd456f0f9: targ: Handle errors from suword()

Summary

In targstart() we are already handling an error and have no go way to
signal the failure to upper layers, so ignore the return value of
suword() there.

This is in preparation for annotating copyin() and related functions
with __result_use_check.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Dec 26 2023, 11:57 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 26 2023, 11:57 PM

markj requested review of this revision.Dec 26 2023, 11:57 PM

Harbormaster completed remote builds in B55130: Diff 131887.Dec 26 2023, 11:58 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jan 4 2024, 1:41 PM

Closed by commit rG904cd456f0f9: targ: Handle errors from suword() (authored by markj). · Explain Why

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG904cd456f0f9: targ: Handle errors from suword().

markj added a commit: rG185634d86d96: targ: Handle errors from suword().Jan 11 2024, 2:34 PM

Revision Contents
Changeset List

Path

Size

sys/

cam/

scsi/

scsi_target.c

9 lines

Diff 132268

View Options

sys/cam/scsi/scsi_target.c

targ: Handle errors from suword()ClosedPublicActions