Differential D4270

Have syslogd honor 'mesg' status when logging to users.
ClosedPublic
Actions

Authored by • lidl on Nov 24 2015, 8:38 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Apr 8, 2:57 AM

	Unknown Object (File)
	Thu, Mar 28, 9:52 AM

	Unknown Object (File)
	Thu, Mar 21, 10:14 PM

	Unknown Object (File)
	Thu, Mar 21, 10:13 PM

	Unknown Object (File)
	Jan 5 2024, 4:14 PM

	Unknown Object (File)
	Jan 5 2024, 4:14 PM

	Unknown Object (File)
	Jan 5 2024, 4:14 PM

	Unknown Object (File)
	Jan 5 2024, 4:14 PM

View All 72 Files

Subscribers

Details

Reviewers

Commits

rS291328: Have syslogd honor 'mesg' status when logging to users.

Summary

Proposed commit message:

PR: bin/196742
Submitted by: jef at mail acme com
Approved by: rpaulo (mentor)
Differential Revision: https://reviews.freebsd.org/D4270

Test Plan

Setup a syslogd configuration that logs to a user.
Login to two different ttys on machine, use 'logger' to
send distinct message to the facility that logs to the user.
Verify that both logins receive the messages.

Use 'mesg n' to turn off messages to the first user. Verify that
the syslog daemon only writes to the second user (mesg y).

Use 'mesg y' to back on messages to the first user. Use 'mesg n'
to turn off messages to the second user. Verify that only
the first user now receives messages.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• lidl updated this revision to Diff 10480.Nov 24 2015, 8:38 PM

• lidl retitled this revision from to Have syslogd honor 'mesg' status when logging to users..

• lidl updated this object.

• lidl edited the test plan for this revision. (Show Details)

• lidl added a reviewer: rpaulo.

Herald added a subscriber: imp. · View Herald TranscriptNov 24 2015, 8:38 PM

• lidl updated this object.Nov 24 2015, 8:40 PM

rpaulo added inline comments.Nov 25 2015, 5:25 AM

usr.sbin/syslogd/syslogd.c
1452 ↗	(On Diff #10480)	I think it would be cleaner to use snprintf here.

OK, changed to be snprintf.

Address review comment to use snprintf() rather than strcpy().

rpaulo accepted this revision.Nov 25 2015, 6:07 PM

rpaulo edited edge metadata.

This revision is now accepted and ready to land.Nov 25 2015, 6:07 PM

Closed by commit rS291328: Have syslogd honor 'mesg' status when logging to users. (authored by • lidl). · Explain WhyNov 25 2015, 8:01 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

usr.sbin/

syslogd/

26 lines

Diff 10499

head/usr.sbin/syslogd/syslogd.c

Loading...