Page MenuHomeFreeBSD
Differential D4238

elfcopy: exclude extension when converting from binary
ClosedPublic
Actions

Authored by emaste on Nov 20 2015, 9:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 9, 9:03 AM
Unknown Object (File)
Tue, Oct 7, 2:52 PM
Unknown Object (File)
Tue, Oct 7, 2:36 AM
Unknown Object (File)
Mon, Oct 6, 5:40 PM
Unknown Object (File)
Mon, Oct 6, 4:11 PM
Unknown Object (File)
Mon, Oct 6, 4:08 PM
Unknown Object (File)
Thu, Oct 2, 5:55 AM
Unknown Object (File)
Sat, Sep 27, 2:04 AM
View All Files
Subscribers
None

Details

Reviewers
imp
Commits
rS291958: elfcopy: exclude extension when converting from binary
Summary

When converting from binary to ELF, elfcopy creates symbols _binary_<filename>_start_, _binary_<filename>_end, and _binary_<filename>_size. For compatibility with GNU objcopy (and to produce sensible symbol names) the extension must be stripped off.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste updated this revision to Diff 10389.Nov 20 2015, 9:46 PM
emaste retitled this revision from to elfcopy: exclude extension when converting from binary.
emaste updated this object.
emaste edited the test plan for this revision. (Show Details)
emaste added a reviewer: imp.
imp accepted this revision.Dec 7 2015, 8:12 PM
imp edited edge metadata.

looks good to me. At least one test I ran with this a few weeks ago worked.

This revision is now accepted and ready to land.Dec 7 2015, 8:12 PM
Closed by commit rS291958: elfcopy: exclude extension when converting from binary (authored by emaste). · Explain WhyDec 7 2015, 8:21 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
contrib/
elftoolchain/
elfcopy/
13 lines

Diff 10889

View Options

head/contrib/elftoolchain/elfcopy/binary.c

Loading...