Page MenuHomeFreeBSD

graphics/lensfun: Update to 0.3.2
ClosedPublic

Authored by dumbbell on Nov 19 2015, 7:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 10, 4:48 AM
Unknown Object (File)
Oct 19 2024, 7:13 AM
Unknown Object (File)
Oct 5 2024, 10:57 AM
Unknown Object (File)
Oct 5 2024, 8:51 AM
Unknown Object (File)
Oct 3 2024, 11:12 PM
Unknown Object (File)
Oct 2 2024, 9:16 PM
Unknown Object (File)
Oct 2 2024, 6:22 PM
Unknown Object (File)
Oct 2 2024, 9:33 AM
Subscribers

Details

Reviewers
danfe
kwm
Summary

Beside the update to lensfun 0.3.2, apply the patch from bug 200028 to fix the build on ARM.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 1335
Build 1340: arc lint + arc unit

Event Timeline

dumbbell retitled this revision from to graphics/lensfun: Update to 0.3.2.
dumbbell updated this object.
dumbbell edited the test plan for this revision. (Show Details)
dumbbell added reviewers: danfe, kwm.
graphics/lensfun/Makefile
20–28

There's something weird with these flags starting from version 0.3.1; e.g. looks like -DBUILD_AUXFUN:BOOL=ON no longer results in having libauxfun.so (see below). Also, in my lensfun-wip/Makefile I also add -DBUILD_LENSTOOL:BOOL=ON for some reason...

graphics/lensfun/pkg-plist
6

When I've attempted to update this port to version 0.3.1 some time ago, I've stumbled upon the fact that libauxfun.so is gone, and was not sure if this would break any consumer port.

Did you try to understand what happened here? Was it merged with the main library of something?

6–58

I wonder why they've moved these under version_1, will have a closer look.

graphics/lensfun/Makefile
20–28

I don't know the reason libauxfun.so is no longer installed.

I'm ok to build lenstool and the helper scripts too. I never ran them but that could be useful.

graphics/lensfun/pkg-plist
6–58

According to the changelog:

Support for parallel installation of different database versions

Well all users of lensfun need to be check for usage of the missing library.

It seems to be changed in this commit: http://sourceforge.net/p/lensfun/code/ci/d8ae3d962fbdc2598b1d16770d27415083eed47a/

mmoll added inline comments.
graphics/lensfun/Makefile
35

Sorry, I hadn't seen this review earlier, a patch for PR 200028 was committed in rP402504, so please "rebase" this :)

dumbbell edited edge metadata.

Update patch after PR 200028 commit

Remove empty line at the end of pkg-plist

Refresh patch, after commits to the Ports tree

Use USES=pathfix instead of custom post-patch target

kwm edited edge metadata.

Build of the ports that depend on lensfun:
http://meatwad.mouf.net/rubick/poudriere/build.html?mastername=101amd64-kwm&build=2016-02-12_18h25m06s

I grepped the logs for auxfun, and only in lensfun (libs/lensfun/auxfun.cpp) is it mentioned. So there are no users for the library.

This revision is now accepted and ready to land.Feb 12 2016, 11:45 PM

@danfe: Do you have any comment? Should I commit the update?