Page MenuHomeFreeBSD

sys/sys: Check for __ASSEMBLER__ in elf_common.h
ClosedPublic

Authored by andrew on Oct 16 2023, 3:07 PM.
Tags
None
Referenced Files
F142443905: D42224.id129162.diff
Tue, Jan 20, 12:36 AM
Unknown Object (File)
Sun, Jan 18, 2:46 AM
Unknown Object (File)
Sat, Jan 10, 10:35 AM
Unknown Object (File)
Thu, Dec 25, 8:32 PM
Unknown Object (File)
Mon, Dec 22, 12:49 PM
Unknown Object (File)
Dec 12 2025, 2:29 AM
Unknown Object (File)
Dec 11 2025, 3:32 AM
Unknown Object (File)
Dec 10 2025, 10:59 PM
Subscribers

Details

Summary

When preprocessing assembly files with clang or gcc the ASSEMBLER
macro is defined. Check for this as an alternative to LOCORE in
elf_common.h so it can be included by .S files.

Sponsored by: Arm Ltd

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This is fine...

But maybe we don't need the LOCORE hack at all if all assemblers define ASSEMBLER now?

This revision is now accepted and ready to land.Oct 16 2023, 3:09 PM

I don't think we need LOCORE. I can follow up with a commit to remove LOCORE, although I'm unsure if we have anything that depends on it (either base or ports)