etc: remove leftover leading empty comments, blank lines
ClosedPublic
Actions

Authored by karels on Aug 22 2023, 12:32 PM.

Details

Reviewers

Commits

rGb67a8f006d3c: etc: remove leftover leading empty comments, blank lines
rG9d6049d5da8c: etc: remove leftover leading empty comments, blank lines

Summary

Remove leftover empty leading comments/blank lines that had been
spacers between $FreeBSD$ and the following content in config files
in src/etc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

karels requested review of this revision.Aug 22 2023, 12:32 PM

karels created this revision.

Harbormaster completed remote builds in B53235: Diff 126370.Aug 22 2023, 12:32 PM

I'm not sure all of these should go... lemme check history first

Not sure about the specific ones I flagged, mostly because of trailing '#' lines.
These comments weren't in 4.4BSD and when FreeBDS added comments,
we went from a single # $Id:$ line to that, a blank # line, the comment and
a trailing # line. Weak surmise is that the leading and trailing # were intended.
But I'm not that excited either way.

The rest are fine, no question.

etc/mail/access.sample
2 ↗	(On Diff #126370)	I think this one should stay given the trailing #
etc/mail/mailer.conf
2 ↗	(On Diff #126370)	ditto
etc/mail/mailertable.sample
2 ↗	(On Diff #126370)	ditto
etc/mail/virtusertable.sample
2 ↗	(On Diff #126370)	ditto
etc/mtree/BSD.debug.dist
2 ↗	(On Diff #126370)	ditto for all the etc/mtree stuff

This revision is now accepted and ready to land.Aug 22 2023, 5:34 PM

karels added inline comments.Aug 22 2023, 5:53 PM

etc/mtree/BSD.debug.dist
2 ↗	(On Diff #126370)	Does that include mtree/Makefile and mtree/README? Both had leading blank lines.

imp added inline comments.Aug 22 2023, 5:56 PM

etc/mtree/BSD.debug.dist
2 ↗	(On Diff #126370)	Does that include mtree/Makefile and mtree/README? Both had leading blank lines. No. Those look like they should be removed imho.