Page MenuHomeFreeBSD

devel/csfml: New Port, CSFML, C bindings to the Simple and Fast Multimedia Library
ClosedPublic

Authored by agh_riseup.net on Aug 21 2023, 4:22 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 17, 11:31 AM
Unknown Object (File)
Fri, Jan 17, 10:48 AM
Unknown Object (File)
Mon, Jan 13, 8:39 PM
Unknown Object (File)
Mon, Jan 6, 9:47 PM
Unknown Object (File)
Mon, Jan 6, 9:11 PM
Unknown Object (File)
Mon, Jan 6, 9:05 PM
Unknown Object (File)
Sun, Jan 5, 12:04 AM
Unknown Object (File)
Fri, Dec 27, 7:52 PM
Subscribers

Details

Summary

The Simple and Fast Multimedia Library (SFML) exists in devel/sfml. SFML is a C++ library, and as such, may introduce complexity for other languages to use the library. CSFML is an official SFML project to provide C bindings to SFML, with the aim of reducing language binding complexity, to enable other languages to use C over C++.

https://github.com/SFML/CSFML

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

agh_riseup.net created this revision.

Reformat patch with git format-patch.

agh_riseup.net edited the summary of this revision. (Show Details)

Add more categories
Edit pkg-descr, hopefully clearer now
Remove @ from ${MKDIR}

diizzy added inline comments.
devel/csfml/Makefile
2 ↗(On Diff #128697)

PORTVERSION --> DISTVERSION
And can this be bumped to 2.6.0?

20 ↗(On Diff #128697)
25 ↗(On Diff #128697)

Is this needed?

devel/csfml: Address items in review D41519

Address dizzy's comments in review D41519:

  • Use ${DISTVERSION} instead of ${PORTVERSION}
  • Set ${WWW} to the CSFML subproject site in attempt to clarify that the project itself is separate from the main project SFML releases
  • Remove option DOCS and related support, the Readme is very minimal, and provides little advice or help

Differential Revision: https://reviews.freebsd.org/D41519

Thanks for the feedback.

devel/csfml/Makefile
2 ↗(On Diff #128697)

This has been corrected.

20 ↗(On Diff #128697)

I am not sure what I am to do here. CSFML does not produce releases from the main SFML project. CSFML could be considered as sub-project of SFML, where other bindings are not formally part of the project like this. To make things challenging, CSFML releases are not turly synchronised with SFML's releases. So I changed ${WWW} to point to the CSFML download page, in an attempt to make the relationship, and separation of the two projects clearer.

25 ↗(On Diff #128697)

You are correct, this Readme is not needed, and has been removed with the updated diff.

Thanks, I got a bit confused about their "sub-projects". Patch looks good and queued for commit.

This revision is now accepted and ready to land.Oct 21 2023, 4:10 PM