Do not zero memory in umass_detach
ClosedPublic
Actions

Authored by wma_semihalf.com on Nov 13 2015, 12:33 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Nov 7, 12:14 AM

	Unknown Object (File)
	Oct 7 2024, 6:30 AM

	Unknown Object (File)
	Oct 6 2024, 8:38 AM

	Unknown Object (File)
	Oct 3 2024, 10:15 AM

	Unknown Object (File)
	Oct 2 2024, 4:31 PM

	Unknown Object (File)
	Sep 27 2024, 10:10 AM

	Unknown Object (File)
	Sep 15 2024, 6:12 PM

	Unknown Object (File)
	Sep 14 2024, 6:10 AM

View All 60 Files

Subscribers

None

Details

Reviewers

zbb
• hselasky

Summary

The detach function is called very often, for example from
get_capacity function. We don't want to loose any pointers
here, so disable detaching for umass driver.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

wma_semihalf.com updated this revision to Diff 10151.Nov 13 2015, 12:33 PM

wma_semihalf.com retitled this revision from to Do not zero memory in umass_detach.

wma_semihalf.com updated this object.

wma_semihalf.com edited the test plan for this revision. (Show Details)

wma_semihalf.com added reviewers: • hselasky, zbb.

• hselasky added inline comments.Nov 17 2015, 1:47 PM

sys/boot/usb/storage/umass_common.c
85	Can this be left under #ifdef USB_DEBUG What do you think? --HPS

zbb commandeered this revision.Nov 27 2015, 5:09 PM

zbb updated this revision to Diff 10545.

zbb edited reviewers, added: wma_semihalf.com; removed: zbb.

wma_semihalf.com commandeered this revision.Nov 30 2015, 3:08 PM

wma_semihalf.com edited reviewers, added: zbb; removed: wma_semihalf.com.

zbb accepted this revision.Nov 30 2015, 3:09 PM

zbb edited edge metadata.

This revision is now accepted and ready to land.Nov 30 2015, 3:09 PM

Already integrated to https://svnweb.freebsd.org/changeset/base/291401

Revision Contents
Changeset List

Path

Size

sys/

boot/

usb/

storage/

umass_common.c

3 lines

Diff 10545

View Options

sys/boot/usb/storage/umass_common.c

Do not zero memory in umass_detachClosedPublicActions