Page MenuHomeFreeBSD

Do not zero memory in umass_detach
ClosedPublic

Authored by wma_semihalf.com on Nov 13 2015, 12:33 PM.

Details

Reviewers
zbb
hselasky
Summary
The detach function is called very often, for example from
get_capacity function. We don't want to loose any pointers
here, so disable detaching for umass driver.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

wma_semihalf.com retitled this revision from to Do not zero memory in umass_detach.
wma_semihalf.com updated this object.
wma_semihalf.com edited the test plan for this revision. (Show Details)
wma_semihalf.com added reviewers: hselasky, zbb.
hselasky added inline comments.Nov 17 2015, 1:47 PM
sys/boot/usb/storage/umass_common.c
85

Can this be left under #ifdef USB_DEBUG

What do you think?

--HPS

zbb commandeered this revision.Nov 27 2015, 5:09 PM
zbb updated this revision to Diff 10545.
zbb edited reviewers, added: wma_semihalf.com; removed: zbb.
wma_semihalf.com commandeered this revision.Nov 30 2015, 3:08 PM
wma_semihalf.com edited reviewers, added: zbb; removed: wma_semihalf.com.
zbb accepted this revision.Nov 30 2015, 3:09 PM
zbb edited edge metadata.
This revision is now accepted and ready to land.Nov 30 2015, 3:09 PM