Page MenuHomeFreeBSD

Do not zero memory in umass_detach
ClosedPublic

Authored by wma_semihalf.com on Nov 13 2015, 12:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 24, 6:12 PM
Unknown Object (File)
Feb 23 2024, 3:24 PM
Unknown Object (File)
Dec 19 2023, 11:46 PM
Unknown Object (File)
Dec 9 2023, 10:39 PM
Unknown Object (File)
Nov 13 2023, 1:28 PM
Unknown Object (File)
Nov 4 2023, 11:50 PM
Unknown Object (File)
Oct 25 2023, 9:00 AM
Unknown Object (File)
Oct 23 2023, 4:01 AM
Subscribers
None

Details

Reviewers
zbb
hselasky
Summary
The detach function is called very often, for example from
get_capacity function. We don't want to loose any pointers
here, so disable detaching for umass driver.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

wma_semihalf.com retitled this revision from to Do not zero memory in umass_detach.
wma_semihalf.com updated this object.
wma_semihalf.com edited the test plan for this revision. (Show Details)
wma_semihalf.com added reviewers: hselasky, zbb.
sys/boot/usb/storage/umass_common.c
85

Can this be left under #ifdef USB_DEBUG

What do you think?

--HPS

zbb updated this revision to Diff 10545.
zbb edited reviewers, added: wma_semihalf.com; removed: zbb.
wma_semihalf.com edited reviewers, added: zbb; removed: wma_semihalf.com.
zbb edited edge metadata.
This revision is now accepted and ready to land.Nov 30 2015, 3:09 PM