Page MenuHomeFreeBSD

editors/emacs-devel: Miscellaneous refinements
ClosedPublic

Authored by yasu on Jul 30 2023, 12:19 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 22, 1:38 AM
Unknown Object (File)
Mon, Apr 22, 1:38 AM
Unknown Object (File)
Mon, Apr 22, 1:38 AM
Unknown Object (File)
Mon, Apr 22, 1:38 AM
Unknown Object (File)
Sat, Apr 20, 7:32 AM
Unknown Object (File)
Feb 20 2024, 10:36 PM
Unknown Object (File)
Feb 17 2024, 10:35 AM
Unknown Object (File)
Feb 17 2024, 10:35 AM
Subscribers

Details

Summary
  • Use "USES=makeinfo" instead of adding print/texinfo to BUILD_DEPENDS.
  • Revive MOTIF option. Upstream once removed support of Motif but it was reverted later.
  • Update CAIRO_DESC. This option prevents XFT now.
  • Update OTF_DESC. This option doesn't imply XTF any more.
  • Pet portclippy.
Test Plan

Build of following 3 conditions succeeds with poudriere and 13.2-RELEASE amd64 jail.

  • full flavor with default options setting.
  • nox flavor with default options setting.
  • full flavor with MOTIF option enabled.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

yasu requested review of this revision.Jul 30 2023, 12:19 AM
This revision is now accepted and ready to land.Aug 9 2023, 2:44 PM
ashish requested changes to this revision.Aug 10 2023, 9:40 AM

Apologies for sitting on this differential for so long.

I guess we should address following applicable concerns with the port which you discovered while preparing for upcoming editors/emacs update:

  • When MODULES option is OFF and TREESITTER option is ON, link error happens.
  • When PGTK option is ON and SCROLLBARS is OFF configure fails.

Thanks again for finding the issues, and sorry for the delay in my feedback.

This revision now requires changes to proceed.Aug 10 2023, 9:40 AM
  • Make PGTK imply SCROLLBARS.
  • Make TREESITTER imply MODULES.
This revision was not accepted when it landed; it landed in state Needs Review.Aug 12 2023, 4:35 AM
This revision was automatically updated to reflect the committed changes.