Page MenuHomeFreeBSD

Kill WANT_SDL/HAVE_SDL
ClosedPublic

Authored by AMDmi3 on Nov 6 2015, 9:05 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 21, 6:18 AM
Unknown Object (File)
Dec 25 2024, 6:23 AM
Unknown Object (File)
Oct 31 2024, 2:44 PM
Unknown Object (File)
Oct 4 2024, 1:51 PM
Unknown Object (File)
Oct 3 2024, 11:52 PM
Unknown Object (File)
Oct 3 2024, 3:17 PM
Unknown Object (File)
Oct 2 2024, 5:54 AM
Unknown Object (File)
Oct 1 2024, 7:49 AM
Subscribers

Details

Summary

WANT_SDL/HAVE_SDL macros allow a port to check which SDL components are installed.

These go against the policy of avoiding automatic dependencies, and there are also no cases in the portstree where it is used properly.

So, remove these knobs.

Test Plan

Tested all affected ports with poudriere

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 1052
Build 1055: arc lint + arc unit

Event Timeline

AMDmi3 retitled this revision from to Kill WANT_SDL/HAVE_SDL.
AMDmi3 updated this object.
AMDmi3 edited the test plan for this revision. (Show Details)

Can you add WANT_SDL to bsd.sanity.mk ?

AMDmi3 edited edge metadata.

Added WANT_SDL to bsd.sanity.mk

Shouldn't some of these ports be switched to USE_SDL ?

Mk/bsd.sanity.mk
157

Maybe add a bit about "if you need SDL, use USE_SDL" or something.

In D4093#85803, @mat wrote:

Shouldn't some of these ports be switched to USE_SDL ?

No. If they use SDL, they already use USE_SDL. WANT_SDL does nothing unless you check for HAVE_SDL. Apart from noegnud*, which checked it for no reason, no port checks HAVE_SDL at all.

AMDmi3 edited edge metadata.

Extend message

Mk/bsd.sanity.mk
156–158

It should be an error as it's not supported, and I guess it should go in the list below.

mat added a reviewer: mat.
mat added inline comments.
Mk/bsd.sanity.mk
156–158

Or not, forget about that.

This revision is now accepted and ready to land.Nov 9 2015, 2:04 PM
This revision was automatically updated to reflect the committed changes.