sys: Add [u]divmoddi4 intrinsics on i386.
ClosedPublic
Actions

Authored by jhb on Jun 30 2023, 9:56 PM.

Details

Reviewers

Commits

rGcc4f247fb946: sys: Add [u]divmoddi4 intrinsics on i386.

Summary

GCC 12 uses these in several places when building the i386 kernel.
They are very similar to [u]divdiv3 except that they return both
the quotient and the remainder.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb requested review of this revision.Jun 30 2023, 9:56 PM

jhb created this revision.

Harbormaster completed remote builds in B52369: Diff 124045.Jun 30 2023, 9:56 PM

jhb mentioned this in D40812: i386: Link kernel against libcompiler_rt when using GCC..Jun 30 2023, 9:57 PM

Assuming the code is right (and a quick look says it is) then the build integration looks good. It's always built, but only used if referenced... and we have a number of things like that. The extra build time is in the noise for any system that can build the kernel.

This revision is now accepted and ready to land.Jun 30 2023, 10:03 PM

Closed by commit rGcc4f247fb946: sys: Add [u]divmoddi4 intrinsics on i386. (authored by jhb). · Explain WhyJul 1 2023, 7:23 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGcc4f247fb946: sys: Add [u]divmoddi4 intrinsics on i386..