Page MenuHomeFreeBSD
Differential D4043

net80211: eliminate copy-paste nearby ieee80211_check_rxseq()
ClosedPublic
Actions

Authored by avos on Oct 30 2015, 8:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Sep 10, 5:55 AM
Unknown Object (File)
Sun, Sep 6, 10:33 AM
Unknown Object (File)
Sat, Sep 5, 3:34 PM
Unknown Object (File)
Fri, Sep 4, 9:24 AM
Unknown Object (File)
Fri, Sep 4, 3:34 AM
Unknown Object (File)
Fri, Sep 4, 1:49 AM
Unknown Object (File)
Wed, Sep 2, 3:22 AM
Unknown Object (File)
Wed, Sep 2, 3:05 AM
View All Files
Subscribers
imp

Details

Reviewers
adrian
Commits
rS296254: net80211: eliminate copy-paste nearby ieee80211_check_rxseq()

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

avos updated this revision to Diff 9835.Oct 30 2015, 8:38 PM
avos retitled this revision from to net80211: eliminate copy-paste nearby ieee80211_check_rxseq().
avos updated this object.
avos edited the test plan for this revision. (Show Details)
avos added a reviewer: adrian.
avos set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added a subscriber: imp. · View Herald TranscriptOct 30 2015, 8:38 PM
adrian added inline comments.Oct 30 2015, 10:00 PM
sys/net80211/ieee80211_adhoc.c
441 ↗(On Diff #9835)

.. what about the rxseqs[] assignment here? Where's it now being done?

avos added inline comments.Oct 30 2015, 10:16 PM
sys/net80211/ieee80211_adhoc.c
441 ↗(On Diff #9835)

in the ieee80211_check_rxseq() ('ok' path)

adrian added inline comments.Oct 30 2015, 10:27 PM
sys/net80211/ieee80211_adhoc.c
441 ↗(On Diff #9835)

It looks like in this patch you removed all of the instances though!

avos added inline comments.Oct 30 2015, 10:30 PM
sys/net80211/ieee80211_input.h
241 ↗(On Diff #9835)

this?

avos added inline comments.Oct 31 2015, 10:59 PM
sys/net80211/ieee80211_adhoc.c
441 ↗(On Diff #9835)

I've just moved duplicated code into ieee80211_check_rxseq() (so, this patch should be a noop)

adrian accepted this revision.Mar 1 2016, 4:29 AM
adrian edited edge metadata.

damn, how'd I miss that! sorry! go for it!

This revision is now accepted and ready to land.Mar 1 2016, 4:29 AM
Closed by commit rS296254: net80211: eliminate copy-paste nearby ieee80211_check_rxseq() (authored by avos). · Explain WhyMar 1 2016, 6:47 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
net80211/
19 lines
19 lines
26 lines
19 lines
19 lines
17 lines

Diff 13920

View Options

head/sys/net80211/ieee80211_adhoc.c

Loading...
View Options

head/sys/net80211/ieee80211_hostap.c

Loading...
View Options

head/sys/net80211/ieee80211_input.h

Loading...
View Options

head/sys/net80211/ieee80211_mesh.c

Loading...
View Options

head/sys/net80211/ieee80211_sta.c

Loading...
View Options

head/sys/net80211/ieee80211_wds.c

Loading...