bxe: Add 2500baseX SFF underpinning

[luca.piccirillo_gmail.com]

sys/dev/bxe/bxe.c

13873

On dslreports I see many times this same patch with this condition added to the above ELINK_ETH_PHY_XFP_FIBER case instead. Which one is correct?

[adam.jaremko_freebsd_gmail.com]

sys/dev/bxe/bxe.c

13873

On dslreports I see many times this same patch with this condition added to the above ELINK_ETH_PHY_XFP_FIBER case instead. Which one is correct?

This is the correct condition because 2.5G enablement is dependent on 1G advertisement and the media type should be set to ELINK_ETH_PHY_SFP_1G_FIBER (As seen in the changes below in elink_get_edc_mode). The problem lies in how the transceivers eeprom was programmed and if its compliance code is correctly set to begin with. As you can guess, this is rarely the case, hence the dslreports diff. For obvious reasons there isn't code to handle these manufacturer issues.

I settled on correctness vs hacks.

[adam.jaremko_freebsd_gmail.com]

sys/dev/bxe/bxe.c

13873

On second thought, it's probably best to remove this altogether as there is no way to determine if the transceiver actually supports 2.5 from SFF-8472.