Page MenuHomeFreeBSD
Differential D40202

devel/corrade: fix build on aarch64, missing FreeBSD code
ClosedPublic
Actions

Authored by fuz on May 22 2023, 12:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 21, 9:53 AM
Unknown Object (File)
Mon, May 18, 1:35 PM
Unknown Object (File)
Wed, May 13, 2:10 AM
Unknown Object (File)
Wed, May 13, 1:35 AM
Unknown Object (File)
Wed, May 13, 12:55 AM
Unknown Object (File)
Tue, May 12, 6:33 PM
Unknown Object (File)
Tue, May 12, 7:33 AM
Unknown Object (File)
Tue, May 12, 7:10 AM
View All Files
Subscribers
mat

Details

Reviewers
yuri
Commits
R11:2313549e74be: devel/corrade: fix build on aarch64, missing FreeBSD code
Summary
devel/corrade: fix build on aarch64, missing FreeBSD code

 - add CPU detection code for armv7, aarch64
   (armv7 is still broken for other reasons)
 - add missing FreeBSD support code for executableLocation()
 - hook up test suite

See also:	https://github.com/mosra/corrade/issues/171
Test Plan

Ran make test and fixed what I could.
Builds fine in Poudriere.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

fuz created this revision.May 22 2023, 12:38 PM
Herald added a subscriber: mat. · View Herald TranscriptMay 22 2023, 12:38 PM
fuz requested review of this revision.May 22 2023, 12:38 PM
Harbormaster completed remote builds in B51591: Diff 122209.May 22 2023, 12:38 PM
fuz updated this revision to Diff 122211.May 22 2023, 12:40 PM

Update to fixed patch.

Harbormaster completed remote builds in B51593: Diff 122211.May 22 2023, 12:40 PM
fuz updated this revision to Diff 122212.May 22 2023, 12:43 PM

Upload fixed fixed patch.

Harbormaster completed remote builds in B51594: Diff 122212.May 22 2023, 12:43 PM
fuz added a comment.May 24 2023, 3:52 PM

Any news on this one?

yuri accepted this revision.May 24 2023, 4:27 PM

Approved,
Please commit it.

This revision is now accepted and ready to land.May 24 2023, 4:27 PM
Closed by commit R11:2313549e74be: devel/corrade: fix build on aarch64, missing FreeBSD code (authored by fuz). · Explain WhyMay 25 2023, 9:44 AM
This revision was automatically updated to reflect the committed changes.
fuz added a commit: R11:2313549e74be: devel/corrade: fix build on aarch64, missing FreeBSD code.

Revision Contents
Changeset List

Diff 122401

View Options

devel/corrade/Makefile

Loading...
View Options

devel/corrade/files/patch-src_Corrade_Cpu.h

Loading...
View Options

devel/corrade/files/patch-src_Corrade_Cpu.cpp

Loading...
View Options

devel/corrade/files/patch-src_Corrade_Utility_Path.cpp

Loading...