Page MenuHomeFreeBSD

run(4): convert to ieee80211_tx_complete()
ClosedPublic

Authored by avos on Oct 23 2015, 4:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 15, 6:08 AM
Unknown Object (File)
Sep 17 2025, 10:10 PM
Unknown Object (File)
Sep 13 2025, 2:26 AM
Unknown Object (File)
Sep 12 2025, 11:06 PM
Unknown Object (File)
Sep 7 2025, 5:35 AM
Unknown Object (File)
Aug 20 2025, 9:36 PM
Unknown Object (File)
Aug 15 2025, 2:47 AM
Unknown Object (File)
Aug 11 2025, 10:46 PM
Subscribers

Details

Test Plan

(untested, should be noop)

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

avos retitled this revision from to run(4): convert to ieee80211_tx_complete().
avos updated this object.
avos edited the test plan for this revision. (Show Details)
avos added reviewers: adrian, kevlo.
avos set the repository for this revision to rS FreeBSD src repository - subversion.
sys/dev/usb/wlan/if_run.c
3034 ↗(On Diff #9664)

This is now being called regardless of whether data->m is NULL.

Let's ensure we don't call it if data->m is NULL.

(And yes, we should get you some hardware.)

sys/dev/usb/wlan/if_run.c
3034 ↗(On Diff #9664)

Is it possible? (run_tx() / run_tx_mgt() / run_sendprot() / run_tx_param() will never initialize data->m / data->ni to NULL).

Ah, ok. this is slightly different to other drivers where this function would also be called when tearing down the queues (eg during XXX_stop()). Ok.

adrian edited edge metadata.

We can fix any unintended consequences later; this is definitely cleaner. go for it!

This revision is now accepted and ready to land.Oct 23 2015, 4:55 PM
This revision was automatically updated to reflect the committed changes.