run(4): convert to ieee80211_tx_complete()
ClosedPublic
Actions

Authored by avos on Oct 23 2015, 4:21 PM.

Details

Reviewers

kevlo
adrian

Commits

rS289841: run(4): convert to ieee80211_tx_complete()

Test Plan

(untested, should be noop)

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

avos updated this revision to Diff 9664.Oct 23 2015, 4:21 PM

avos retitled this revision from to run(4): convert to ieee80211_tx_complete().

avos updated this object.

avos edited the test plan for this revision. (Show Details)

avos added reviewers: adrian, kevlo.

avos set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptOct 23 2015, 4:21 PM

adrian added inline comments.Oct 23 2015, 4:47 PM

sys/dev/usb/wlan/if_run.c
3034 ↗	(On Diff #9664)	This is now being called regardless of whether data->m is NULL. Let's ensure we don't call it if data->m is NULL. (And yes, we should get you some hardware.)

avos added inline comments.Oct 23 2015, 4:50 PM

sys/dev/usb/wlan/if_run.c
3034 ↗	(On Diff #9664)	Is it possible? (run_tx() / run_tx_mgt() / run_sendprot() / run_tx_param() will never initialize data->m / data->ni to NULL).

Ah, ok. this is slightly different to other drivers where this function would also be called when tearing down the queues (eg during XXX_stop()). Ok.

We can fix any unintended consequences later; this is definitely cleaner. go for it!

This revision is now accepted and ready to land.Oct 23 2015, 4:55 PM

Closed by commit rS289841: run(4): convert to ieee80211_tx_complete() (authored by avos). · Explain WhyOct 23 2015, 5:35 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

usb/

wlan/

if_run.c

17 lines

Diff 9665

View Options

head/sys/dev/usb/wlan/if_run.c

run(4): convert to ieee80211_tx_complete()ClosedPublicActions