Page MenuHomeFreeBSD
Differential D3897

do not FALLTHROUGH for SIOC{ADD,DEL}MULTI
ClosedPublic
Actions

Authored by sjg on Oct 15 2015, 12:02 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 4, 11:15 PM
Unknown Object (File)
Feb 22 2025, 6:07 PM
Unknown Object (File)
Feb 7 2025, 1:25 PM
Unknown Object (File)
Jan 22 2025, 9:57 PM
Unknown Object (File)
Oct 28 2024, 9:48 PM
Unknown Object (File)
Oct 28 2024, 9:48 PM
Unknown Object (File)
Oct 28 2024, 9:31 PM
Unknown Object (File)
Oct 3 2024, 2:17 PM
View All 45 Files
Subscribers
None

Details

Reviewers
marcel
Summary

FALLTHROUGH results in return of EINVAL since ifmedia_ioctl()
does not grok SIOC{ADD,DEL}MULTI

This hurts if caller is paying attention to errors.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 769
Build 769: arc lint + arc unit

Event Timeline

sjg updated this revision to Diff 9398.Oct 15 2015, 12:02 AM
sjg retitled this revision from to do not FALLTHROUGH for SIOC{ADD,DEL}MULTI.
sjg updated this object.
sjg edited the test plan for this revision. (Show Details)
sjg added a reviewer: marcel.Oct 30 2015, 4:47 AM
marcel accepted this revision.Oct 30 2015, 4:20 PM
marcel edited edge metadata.

LGTM

This revision is now accepted and ready to land.Oct 30 2015, 4:20 PM
marcel closed this revision.Sep 24 2016, 4:31 PM

Code was committed.

Revision Contents
Changeset List

PathSize
sys/
dev/
xen/
netfront/
2 lines

Diff 9398

View Options

sys/dev/xen/netfront/netfront.c

Loading...