do not FALLTHROUGH for SIOC{ADD,DEL}MULTI
ClosedPublic
Actions

Authored by sjg on Oct 15 2015, 12:02 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Oct 14, 12:59 PM

	Unknown Object (File)
	Sat, Oct 11, 3:50 AM

	Unknown Object (File)
	Sun, Oct 5, 8:16 PM

	Unknown Object (File)
	Sun, Oct 5, 9:08 AM

	Unknown Object (File)
	Sun, Oct 5, 8:53 AM

	Unknown Object (File)
	Sun, Oct 5, 8:40 AM

	Unknown Object (File)
	Sep 21 2025, 11:12 PM

	Unknown Object (File)
	Sep 17 2025, 5:48 AM

View All 67 Files

Subscribers

None

Details

Reviewers

marcel

Summary

FALLTHROUGH results in return of EINVAL since ifmedia_ioctl()
does not grok SIOC{ADD,DEL}MULTI

This hurts if caller is paying attention to errors.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 769
Build 769: arc lint + arc unit

Event Timeline

sjg updated this revision to Diff 9398.Oct 15 2015, 12:02 AM

sjg retitled this revision from to do not FALLTHROUGH for SIOC{ADD,DEL}MULTI.

sjg updated this object.

sjg edited the test plan for this revision. (Show Details)

sjg added a reviewer: marcel.Oct 30 2015, 4:47 AM

LGTM

This revision is now accepted and ready to land.Oct 30 2015, 4:20 PM

Code was committed.

Revision Contents
Changeset List

Path

Size

sys/

dev/

xen/

netfront/

netfront.c

2 lines

Diff 9398

View Options

sys/dev/xen/netfront/netfront.c

do not FALLTHROUGH for SIOC{ADD,DEL}MULTIClosedPublicActions