do not FALLTHROUGH for SIOC{ADD,DEL}MULTI
ClosedPublic
Actions

Authored by sjg on Oct 15 2015, 12:02 AM.

Tags

None

Referenced Files

	F151952536: D3897.diff
	Sat, Apr 11, 5:51 PM

	F151860281: D3897.diff
	Sat, Apr 11, 4:15 AM

	Unknown Object (File)
	Fri, Apr 10, 11:13 PM

	Unknown Object (File)
	Tue, Apr 7, 1:25 PM

	Unknown Object (File)
	Tue, Apr 7, 9:30 AM

	Unknown Object (File)
	Tue, Apr 7, 7:38 AM

	Unknown Object (File)
	Mon, Apr 6, 3:44 AM

	Unknown Object (File)
	Dec 24 2025, 7:28 PM

View All 82 Files

Subscribers

None

Details

Reviewers

marcel

Summary

FALLTHROUGH results in return of EINVAL since ifmedia_ioctl()
does not grok SIOC{ADD,DEL}MULTI

This hurts if caller is paying attention to errors.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 769
Build 769: arc lint + arc unit

Event Timeline

sjg updated this revision to Diff 9398.Oct 15 2015, 12:02 AM

sjg retitled this revision from to do not FALLTHROUGH for SIOC{ADD,DEL}MULTI.

sjg updated this object.

sjg edited the test plan for this revision. (Show Details)

sjg added a reviewer: marcel.Oct 30 2015, 4:47 AM

LGTM

This revision is now accepted and ready to land.Oct 30 2015, 4:20 PM

Code was committed.

Revision Contents
Changeset List

Path

Size

sys/

dev/

xen/

netfront/

netfront.c

2 lines

Diff 9398

View Options

sys/dev/xen/netfront/netfront.c

do not FALLTHROUGH for SIOC{ADD,DEL}MULTIClosedPublicActions