Page MenuHomeFreeBSD

do not FALLTHROUGH for SIOC{ADD,DEL}MULTI
ClosedPublic

Authored by sjg on Oct 15 2015, 12:02 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 14, 12:59 PM
Unknown Object (File)
Sat, Oct 11, 3:50 AM
Unknown Object (File)
Sun, Oct 5, 8:16 PM
Unknown Object (File)
Sun, Oct 5, 9:08 AM
Unknown Object (File)
Sun, Oct 5, 8:53 AM
Unknown Object (File)
Sun, Oct 5, 8:40 AM
Unknown Object (File)
Sun, Sep 21, 11:12 PM
Unknown Object (File)
Sep 17 2025, 5:48 AM
Subscribers
None

Details

Reviewers
marcel
Summary

FALLTHROUGH results in return of EINVAL since ifmedia_ioctl()
does not grok SIOC{ADD,DEL}MULTI

This hurts if caller is paying attention to errors.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 769
Build 769: arc lint + arc unit

Event Timeline

sjg retitled this revision from to do not FALLTHROUGH for SIOC{ADD,DEL}MULTI.
sjg updated this object.
sjg edited the test plan for this revision. (Show Details)
marcel edited edge metadata.

LGTM

This revision is now accepted and ready to land.Oct 30 2015, 4:20 PM