Page MenuHomeFreeBSD

fix legacy psm/atkbc build after c51978f4b2f0, unlock new settings from NOTES via userland
AbandonedPublic

Authored by fbsd_paepcke.de on Feb 27 2023, 8:02 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 17, 9:16 AM
Unknown Object (File)
Tue, Oct 14, 8:58 PM
Unknown Object (File)
Mon, Oct 13, 3:50 AM
Unknown Object (File)
Sun, Oct 12, 3:25 PM
Unknown Object (File)
Sun, Oct 12, 3:25 PM
Unknown Object (File)
Sun, Oct 12, 3:25 PM
Unknown Object (File)
Sun, Oct 12, 3:25 PM
Unknown Object (File)
Sun, Oct 12, 3:25 PM
Subscribers
None

Details

Reviewers
imp
Summary
  • fixes the build of the legacy psm/atkbc driver after c51978f4b2f0

reported by Mark Millard / discord (sorry for the break!)

  • unlocks the use of the new NOTES featured kbd settings

via 'kbdcontrol -r ultra' from userland as well

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

fbsd_paepcke.de created this revision.

needs a refacor, too many corners to clean up, ignor

I fixed the build issues, but look forward to what we need to do to make things work.

In D38806#883259, @imp wrote:

I fixed the build issues, but look forward to what we need to do to make things work.

yes, but if we need for touch > 9 files, that mange *exact* the same two static tables with exact the same content (if we ignore the several typos), then it needs an cleanup / refactor first.

In D38806#883259, @imp wrote:

I fixed the build issues, but look forward to what we need to do to make things work.

yes, but if we need for touch > 9 files, that mange *exact* the same two static tables with exact the same content (if we ignore the several typos), then it needs an cleanup / refactor first.

Agreed. I fixed the immediate issue, but the problem you points out lingers. There's time for you to do the cleanup / refactor now that the
tree builds again after I broke it last night.

In D38806#883297, @imp wrote:
In D38806#883259, @imp wrote:

I fixed the build issues, but look forward to what we need to do to make things work.

yes, but if we need for touch > 9 files, that mange *exact* the same two static tables with exact the same content (if we ignore the several typos), then it needs an cleanup / refactor first.

Agreed. I fixed the immediate issue, but the problem you points out lingers. There's time for you to do the cleanup / refactor now that the
tree builds again after I broke it last night.

I'm on it! But I need some more time for tests wired corner cases this time.
And thanks for cd29688e8ec5 - fixing it the right way!