Page MenuHomeFreeBSD

freebsd32.h: Include <sys/mount.h>
ClosedPublic

Authored by jfree on Feb 16 2023, 5:45 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Sep 29, 5:27 AM
Unknown Object (File)
Mon, Sep 22, 1:01 PM
Unknown Object (File)
Sep 15 2025, 8:36 PM
Unknown Object (File)
Sep 6 2025, 4:18 AM
Unknown Object (File)
Aug 30 2025, 12:07 AM
Unknown Object (File)
Aug 26 2025, 4:53 PM
Unknown Object (File)
Jul 23 2025, 1:27 AM
Unknown Object (File)
Jul 10 2025, 9:49 PM
Subscribers

Details

Reviewers
brooks
Summary

The freebsd32.h header uses an fsid_t type in struct ostatfs32. Include sys/mount.h to avoid potential compilation errors in situations where it is not already included.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Seems fine.

I'm not entirely convinced struct ostatfs32 shouldn't be defined directly in sys/compat/freebsd32/freebsd32_misc.c, but that's an argument for another day.

This revision is now accepted and ready to land.Feb 16 2023, 6:51 PM

This differential is superseded by this review:
https://reviews.freebsd.org/D40177
which covers some more include self-containment issues in aarch64.