ClosedPublic
Actions

Authored by jfree on Feb 16 2023, 5:45 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Dec 28 2024, 7:06 PM

	Unknown Object (File)
	Dec 6 2024, 6:56 AM

	Unknown Object (File)
	Nov 24 2024, 6:53 PM

	Unknown Object (File)
	Nov 22 2024, 5:18 PM

	Unknown Object (File)
	Nov 20 2024, 5:51 PM

	Unknown Object (File)
	Nov 10 2024, 2:23 PM

	Unknown Object (File)
	Nov 8 2024, 5:01 AM

	Unknown Object (File)
	Nov 6 2024, 11:02 AM

View All 56 Files

Subscribers

imp

Details

Reviewers

brooks

Summary

The freebsd32.h header uses an fsid_t type in struct ostatfs32. Include sys/mount.h to avoid potential compilation errors in situations where it is not already included.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

jfree created this revision.Feb 16 2023, 5:45 AM

Herald added a subscriber: imp. · View Herald TranscriptFeb 16 2023, 5:45 AM

jfree requested review of this revision.Feb 16 2023, 5:45 AM

jfree added a parent revision: D38459: timerfd: Add native support for Linux's timerfd.

Seems fine.

I'm not entirely convinced struct ostatfs32 shouldn't be defined directly in sys/compat/freebsd32/freebsd32_misc.c, but that's an argument for another day.

This revision is now accepted and ready to land.Feb 16 2023, 6:51 PM

This differential is superseded by this review:
https://reviews.freebsd.org/D40177
which covers some more include self-containment issues in aarch64.

jfree closed this revision.May 20 2023, 4:37 AM

jfree removed a parent revision: D38459: timerfd: Add native support for Linux's timerfd.May 21 2023, 2:32 AM