Page MenuHomeFreeBSD
Differential D3844

Enable TEST option when DEVELOPER is enabled
ClosedPublic
Actions

Authored by AMDmi3 on Oct 8 2015, 12:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 22, 5:42 AM
Unknown Object (File)
Mar 23 2024, 10:26 PM
Unknown Object (File)
Dec 22 2023, 9:49 PM
Unknown Object (File)
Nov 26 2023, 9:52 AM
Unknown Object (File)
Nov 22 2023, 12:22 PM
Unknown Object (File)
Nov 14 2023, 12:18 AM
Unknown Object (File)
Nov 11 2023, 10:47 PM
Unknown Object (File)
Nov 11 2023, 10:12 PM
View All 39 Files
Subscribers
marino

Details

Reviewers
bapt
Group Reviewers
portmgr
Commits
rP398829: Enable TEST option if DEVELOPER is set
Summary

As partially planned during do-test implementation and suggested by more people later, enable TEST option by default if DEVELOPER is defined.

I'll remind that TEST option is supposed to be used when a port needs extra dependencies and/or compile options on BUILD phase to enable tests (so TEST_DEPENDS won't work). Now enable it when DEVELOPER is defined so all interested parties (committers/maintainers who set DEVELOPER and Q/A poudriere builds) have tests enabled.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

AMDmi3 updated this revision to Diff 9239.Oct 8 2015, 12:22 PM
AMDmi3 retitled this revision from to Enable TEST option when DEVELOPER is enabled.
AMDmi3 updated this object.
AMDmi3 edited the test plan for this revision. (Show Details)
Herald added a reviewer: portmgr. · View Herald TranscriptOct 8 2015, 12:22 PM
bapt accepted this revision.Oct 8 2015, 12:41 PM
bapt added a reviewer: bapt.
This revision is now accepted and ready to land.Oct 8 2015, 12:41 PM
Closed by commit rP398829: Enable TEST option if DEVELOPER is set (authored by AMDmi3). · Explain WhyOct 8 2015, 2:21 PM
This revision was automatically updated to reflect the committed changes.
AMDmi3 mentioned this in rP398829: Enable TEST option if DEVELOPER is set.
marino added a subscriber: marino.Jun 19 2016, 9:36 AM

AMDmi3,
Please see D6810.
I believe this commit should be reverted due to negative consequences it potentially creates. In fact, I believe options *never*[1] should be automagically set as this is doing.

[1] The default on options like DOCS and NLS excluded

Revision Contents
Changeset List

PathSizePackages
head/
Mk/
4 linesO5: Ports Framework

Diff 9242

View Options

head/Mk/bsd.options.mk

Loading...