thrift: upgrade to version 0.16.0
ClosedPublic
Actions

Authored by mfechner on Oct 20 2022, 2:09 PM.

Details

Reviewers: None
Commits: R11:519e762a6f42: devel/thrift: update to 0.16.0

Summary

Included is a patch to upgrade thrift to version 0.16.0.
I need this update for a newer gitlab version.

If it is ok for you, I would commit it for you.

Test Plan

I testbuild all ports having a thrift in the package name with poudriere bulk -t and I saw no build errors.
But I have not done any functional tests.

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mfechner requested review of this revision.Oct 20 2022, 2:09 PM

mfechner created this revision.

Added archive as download of older apache based programs is broken with commit 34197c5c60d3

diizzy added a subscriber: diizzy.Oct 20 2022, 7:55 PM

diizzy added inline comments.

devel/thrift/bsd.thrift.mk
7	Set MASTER_SITES correctly? https://dlcdn.apache.org/thrift/ and mirrors don't offer 0.16.0 so why are you trying to use APACHE alias as primary site?

It only lists version 0.17.0 and not 0.16.0:

mfechner marked an inline comment as done.Oct 21 2022, 5:51 AM

mfechner added inline comments.

devel/thrift/bsd.thrift.mk
7	Set MASTER_SITES correctly? https://dlcdn.apache.org/thrift/ and mirrors don't offer 0.16.0 so why are you trying to use APACHE alias as primary site? Because it is an apache based software and if the port later can be upgrade to a current version which is currently 0.17.0 this line can be removed again. In my opinion you broke the apache MASTER_SITES definition, so I fix it for this specific version as your commit only includes current versions but not older versions of apache software. In my opinion your change also put an necessary load to the FreeBSD servers to download older distfiles of apache software.