Paths

Table of Contentst

Differential D36695

Mk/Uses/cmake.mk: Define -DNDEBUG when BUILD_TYPE is set to RELEASE
ClosedPublic
Actions

Authored by diizzy on Sep 25 2022, 7:45 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Apr 28, 10:00 PM

	Unknown Object (File)
	Thu, Apr 11, 7:04 AM

	Unknown Object (File)
	Thu, Apr 11, 7:04 AM

	Unknown Object (File)
	Thu, Apr 11, 7:04 AM

	Unknown Object (File)
	Wed, Apr 10, 10:12 AM

	Unknown Object (File)
	Jan 14 2024, 11:22 AM

	Unknown Object (File)
	Jan 5 2024, 4:20 AM

	Unknown Object (File)
	Jan 5 2024, 4:20 AM

View All 40 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

R11:3c5189a0fd4c: Mk/Uses/cmake.mk: Define -DNDEBUG when BUILD_TYPE is set to RELEASE

Summary

CMake defines -DNDEBUG when BUILD_TYPE is set to RELEASE by default however default flags gets dropped when CMAKE_C_FLAGS_RELEASE and CMAKE_CXX_FLAGS_RELEASE are (re)defined. This causes some projects to build with debugging by default which needs to be disabled manually if they do not set -DNDEBUG manually either in ports Makefile and/or in CMake's Makefile. To follow upstream add -DNDEBUG to our RELEASE flags.

Test Plan

exp-run?

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

diizzy requested review of this revision.Sep 25 2022, 7:45 AM

diizzy created this revision.

NDEBUG also disables assertions in C, so this is a good change.

diizzy retitled this revision from Mk/Uses/cmake.mk to Mk/Uses/cmake.mk: Define -DNDEBUG when BUILD_TYPE is set to RELEASE.Sep 25 2022, 8:01 AM

@arrowd
Anything else needed or is it accepted as-is?
Is exp-run needed for this change?

Best regards,
Daniel

diizzy edited the summary of this revision. (Show Details)Sep 30 2022, 9:53 AM

portmgr@ is fine with it

This revision is now accepted and ready to land.Sep 30 2022, 10:30 AM

PR https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=266721 for exp-run request

Closed by commit R11:3c5189a0fd4c: Mk/Uses/cmake.mk: Define -DNDEBUG when BUILD_TYPE is set to RELEASE (authored by diizzy). · Explain WhyOct 29 2022, 7:39 PM

This revision was automatically updated to reflect the committed changes.

diizzy added a commit: R11:3c5189a0fd4c: Mk/Uses/cmake.mk: Define -DNDEBUG when BUILD_TYPE is set to RELEASE.

Revision Contents
Changeset List

Path

Size

Mk/

Uses/

4 lines

Diff 112386

Mk/Uses/cmake.mk

Loading...