Page MenuHomeFreeBSD

editors/emacs-devel: Update to fix build when pgtk knob is off
ClosedPublic

Authored by jrm on Wed, Aug 3, 3:31 PM.

Details

Summary

The update to 3d6af11 introduced a bug that caused the build to fail
when the port's pgtk knob was off.

cc -o temacs.tmp ...

ld: error: undefined symbol: x_scroll_bar_redraw >>> referenced
by xterm.c >>> xterm.o:(XTset_vertical_scroll_bar)

Changes: https://github.com/emacs-mirror/emacs/compare/3d6af11...261d6af

Test Plan

poudriere testport 11/12 i386/amd64 (default options), 14 custom options

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jrm requested review of this revision.Wed, Aug 3, 3:31 PM

I'm not near my FreeBSD desktop for a month, so I can only build test it. A search brought me to this email thread. Did you look at it ?

Thanks!

I hadn't seen the post on emacs-devel@. I had just looked at the commit log and saw, e.g., https://github.com/emacs-mirror/emacs/commit/b7f227ed8bece1a8fafd36ce5f0ee0d5913b6f8b, which fixes the build. I'm running with the update now and all seems fine. I did a quick test with scrollbars, but not with --without-toolkit-scroll-bars.

Pull in another update to fix a second issue that caused the build to fail on i386 with native compilation.

I build tested this on 12/13 i386/amd64 with default options and on a recent CURRENT build with pgtk off.

This revision was not accepted when it landed; it landed in state Needs Review.Thu, Aug 11, 4:10 PM
This revision was automatically updated to reflect the committed changes.