Page MenuHomeFreeBSD

[NEW PORT] comms/cyclonedds: Eclipse Cyclone DDS middleware
ClosedPublic

Authored by flo_purplekraken.com on Sat, Jul 30, 6:22 AM.

Details

Summary
Eclipse Cyclone DDS is a very performant and robust open-source implementation
of the OMG DDS specification. Cyclone DDS is developed completely in the open
as an Eclipse IoT project (see eclipse-cyclone-dds) with a growing list of
adopters (if you're one of them, please add your logo). It is a tier-1
middleware for the Robot Operating System ROS 2.

WWW: https://cyclonedds.io/

Add comms/cyclonedds port.

Test Plan
  • portlint: OK
  • portclippy: OK
  • testport: amd64, 13.1-RELEASE tested

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

flo_purplekraken.com retitled this revision from [NEW PORT] to [NEW PORT] comms/cyclonedds: Eclipse Cyclone DDS middleware.Sat, Jul 30, 6:25 AM
  • Replace PORTVERSION with DISTVERSION.
  • Remove DOCS_DESC.
arrowd requested changes to this revision.Sun, Jul 31, 5:26 PM
arrowd added inline comments.
comms/cyclonedds/Makefile
1

How about CycloneDDS here? This will enable %%DOCSDIR%% substitution in the plist.

This revision now requires changes to proceed.Sun, Jul 31, 5:26 PM

Also, add the port to comms/Makefile.

comms/cyclonedds/Makefile
1

On the other hand it will break the fetch, because the distfiles use the lower-case name:

=> eclipse-cyclonedds-CycloneDDS-0.9.1_GH0.tar.gz is not in /usr/ports/comms/cyclonedds/distinfo.
=> Either /usr/ports/comms/cyclonedds/distinfo is out of date, or
=> eclipse-cyclonedds-CycloneDDS-0.9.1_GH0.tar.gz is spelled incorrectly.

What is the upside of the %%DOCSDIR%% substitution, is it worth it?

Added cyclonedds to comms/Makefile.

comms/cyclonedds/Makefile
1

Add GH_PROJECT=cyclonedds, then.

What is the upside of the %%DOCSDIR%% substitution, is it worth it?

The Ports Framework will recognize these paths as docs and prepend %%PORTDOCS%% too.

  • Rename the port to CycloneDDS
  • Fix option variables
arrowd requested changes to this revision.Sun, Jul 31, 8:46 PM

Building with TESTS enabled results in:

CMake Error at /usr/local/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find CUnit (missing: CUNIT_LIBRARY CUNIT_INCLUDE_DIR)

You need TEST_DEPENDS=....

comms/cyclonedds/Makefile
23

The canonical name for this option is TEST.

This revision now requires changes to proceed.Sun, Jul 31, 8:46 PM
flo_purplekraken.com set the repository for this revision to R11 FreeBSD ports repository.

Fixed the test dependencies; before the failures they were hidden by the invalid use of option flags.

This revision was not accepted when it landed; it landed in state Needs Review.Mon, Aug 1, 5:42 PM
This revision was automatically updated to reflect the committed changes.