Page MenuHomeFreeBSD
Differential D3531

astro/stellarium: Drop USES=iconv.
ClosedPublic
Actions

Authored by rakuco on Aug 29 2015, 11:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 22, 7:09 AM
Unknown Object (File)
Thu, Mar 28, 11:58 PM
Unknown Object (File)
Thu, Mar 28, 9:28 PM
Unknown Object (File)
Mar 16 2024, 2:00 AM
Unknown Object (File)
Feb 19 2024, 1:02 PM
Unknown Object (File)
Feb 19 2024, 12:57 PM
Unknown Object (File)
Feb 19 2024, 12:57 PM
Unknown Object (File)
Feb 19 2024, 6:19 AM
View All 71 Files
Subscribers
None

Details

Reviewers
danfe
Commits
rP395607: Drop USES=iconv.
Summary

Even though the port still has a few FindIconv.cmake files scattered around, they are not actually used by the build system anymore, so the dependency is unnecessary.

Test Plan

Built fine on 10.1-amd64, the most problematic release in terms of iconv support.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rakuco updated this revision to Diff 8342.Aug 29 2015, 11:17 PM
rakuco retitled this revision from to astro/stellarium: Drop USES=iconv..
rakuco updated this object.
rakuco edited the test plan for this revision. (Show Details)
rakuco added a reviewer: danfe.
danfe accepted this revision.Aug 30 2015, 7:25 AM
danfe edited edge metadata.

Fine by me, as long as it builds and iconv library indeed is not needed.

This revision is now accepted and ready to land.Aug 30 2015, 7:25 AM
Closed by commit rP395607: Drop USES=iconv. (authored by rakuco). · Explain WhyAug 30 2015, 10:19 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
astro/
stellarium/
3 lines

Diff 8348

View Options

head/astro/stellarium/Makefile

Loading...