Page MenuHomeFreeBSD

www/node14: Upgrade to 14.19.2
Needs ReviewPublic

Authored by dereks_lifeofadishwasher.com on Fri, May 13, 1:45 AM.

Details

Reviewers
bhughes
Summary

Running with the patch from PR #263090 from i.dani@outlook.com

  • Upgrade to 14.9.2 [1][2][3][4][5] addressing CVE-2021-44531/44532/44533 CVE-2022-21824 CVE-2022-0778
  • portlint, portclippy, portfmt cleanup
  • Add python 3.10 build support
  • Add COREPACK option (enabled by default)
  • Add test target
  • Add patch for failing test due to FreeBSD openssl adding "-freebsd" to version string. [6]
Test Plan
  • portlint ok. 1 expected warning due to error in portlint placing _BROKEN in the wrong location [9]
  • testport {12,13}{amd64,i386} with default options and DEFAULT_VERSIONS= python=python310 python3=python310 make.conf
  • run tests on the above testports
  • build ports that have direct depend on www/node14
    • www/npm-node14
    • www/yarn-node14
  • build textproc/opensearch-dashboards _DEPENDS on www/yarn-node14
  • make extract on devel/electron13 has FETCH/EXTRACT_DEPENDS on www/yarn-node14
  • All testports finshed.
  • make test
      • 13amd64/13i386
          • jstest: ...|% 100|+ 3281|- 2]: Done
        • 2 failing tests appear to be upstream issue [7][8]
    • tooltest: Ran 6 tests in 0.002s
      • 12amd64/i386
          • jstest: ...|% 100|+ 3280|- 3]: Done
        • 2 failing tests appear to be upstream issue [7][8]
        • 1 failing test appears to be due to old openssl on 12.3 (see below)
  • www/npm-node14, www/yarn-node14 built without issue
  • textproc/opensearch-dashboards built without issue
  • devel/electron13 make extract finished wihtout issue

[1] https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V14.md#14.19.2
[2] https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V14.md#14.19.1
[3] https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V14.md#14.19.0
[4] https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V14.md#14.18.3
[5] https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V14.md#14.18.2
[6] https://github.com/nodejs/node/issues/43078
[7] https://github.com/nodejs/node/issues/43079
[8] https://github.com/nodejs/node/issues/43079
[9] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=263859

=== release test-tls-no-sslv3 ===
Path: parallel/test-tls-no-sslv3
CONNECTED(00000003)
---
no peer certificate available
---
No client certificate CA names sent
---
SSL handshake has read 7 bytes and written 58 bytes
Verification: OK
---
New, (NONE), Cipher is (NONE)
Secure Renegotiation IS NOT supported
Compression: NONE
Expansion: NONE
No ALPN negotiated
SSL-Session:
    Protocol  : SSLv3
    Cipher    : 0000
    Session-ID:
    Session-ID-ctx:
    Master-Key:
    PSK identity: None
    PSK identity hint: None
    SRP username: None
    Start Time: 1652397344
    Timeout   : 7200 (sec)
    Verify return code: 0 (ok)
    Extended master secret: no
---
34371141632:error:14094410:SSL routines:ssl3_read_bytes:sslv3 alert handshake failure:/usr/src/crypto/openssl/ssl/record/rec_layer_s3.c:1544:SSL alert number 40
assert.js:394
    throw err;
    ^

AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:

  assert(/:wrong version number/.test(errors[0].message) ||
         /:version too low/.test(errors[0].message))

    at process.<anonymous> (/wrkdirs/usr/ports/www/node14/work/node-v14.19.2/test/parallel/test-tls-no-sslv3.js:46:5)
    at process.emit (events.js:412:35) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: false,
  expected: true,
  operator: '=='
}
Command: out/Release/node /wrkdirs/usr/ports/www/node14/work/node-v14.19.2/test/parallel/test-tls-no-sslv3.js

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 45557
Build 42445: arc lint + arc unit