Differential D35151

multimedia/avidmux: modernize option handling
Needs ReviewPublic
Actions

Authored by tcberner on May 9 2022, 5:29 PM.

Tags

None

Referenced Files

	F146237465: D35151.diff
	Sun, Mar 1, 12:42 AM

	F146227896: D35151.diff
	Sat, Feb 28, 10:41 PM

	F146185843: D35151.diff
	Sat, Feb 28, 1:49 PM

	Unknown Object (File)
	Sat, Feb 21, 6:58 AM

	Unknown Object (File)
	Fri, Feb 20, 3:06 PM

	Unknown Object (File)
	Thu, Feb 19, 5:48 AM

	Unknown Object (File)
	Tue, Feb 17, 5:42 PM

	Unknown Object (File)
	Mon, Feb 16, 10:50 PM

View All 98 Files

Subscribers

lhersch_dssgmbh.de

Details

Reviewers

None

Group Reviewers

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 45501
Build 42389: arc lint + arc unit

Event Timeline

tcberner created this revision.May 9 2022, 5:29 PM

Herald added a subscriber: mat. · View Herald TranscriptMay 9 2022, 5:29 PM

tcberner requested review of this revision.May 9 2022, 5:29 PM

Harbormaster completed remote builds in B45501: Diff 105785.May 9 2022, 5:29 PM

diizzy added a subscriber: diizzy.May 10 2022, 8:14 AM

diizzy added inline comments.

multimedia/avidemux/Makefile.common
151	If you want to avoid if loops you can also use this "trick" https://cgit.freebsd.org/ports/tree/multimedia/ffmpeg/Makefile#n16

tcberner added inline comments.May 10 2022, 9:01 AM

multimedia/avidemux/Makefile.common
151	ah yes, will do.

lhersch_dssgmbh.de added a subscriber: lhersch_dssgmbh.de.Oct 3 2022, 11:10 AM

lhersch_dssgmbh.de added inline comments.

multimedia/avidemux-plugins/Makefile
33	This looks wrong, but it is correct and historically conditioned. PLUGIN_UI QT4 now stands for QT4 and QT5. Whether you actually want to build with QT4 or QT5 is determined by the switches ENABLE_QT5 (cmake/admCheckQt.cmake) and QT4 (cmake/admCheckQt4.cmake).

riggs added a subscriber: riggs.Oct 3 2022, 5:01 PM

riggs added inline comments.

multimedia/avidemux/Makefile.common
36	We have alsa (not in the kernel but libalsa for userspace compatibility), but it's probably fine to disable it unless it is required for some functionality.

Revision Contents
Changeset List

Path

Size

multimedia/

avidemux-plugins/

10 lines

avidemux/

Makefile.common

282 lines

Diff 105785

multimedia/avidemux-plugins/Makefile

Loading...

multimedia/avidemux/Makefile.common

Loading...