Page MenuHomeFreeBSD
Differential D35151

multimedia/avidmux: modernize option handling
Needs ReviewPublic
Actions

Authored by tcberner on May 9 2022, 5:29 PM.
Tags
None
Referenced Files
F105822529: D35151.diff
Sat, Dec 21, 5:51 AM
Unknown Object (File)
Nov 11 2024, 7:00 PM
Unknown Object (File)
Nov 11 2024, 6:43 PM
Unknown Object (File)
Oct 3 2024, 10:25 PM
Unknown Object (File)
Oct 2 2024, 10:00 PM
Unknown Object (File)
Sep 21 2024, 5:32 AM
Unknown Object (File)
Sep 18 2024, 1:05 AM
Unknown Object (File)
Sep 18 2024, 12:44 AM
View All 35 Files
Subscribers
diizzy
lhersch_dssgmbh.de
mat
riggs

Details

Reviewers
None
Group Reviewers
multimedia

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 45501
Build 42389: arc lint + arc unit

Event Timeline

tcberner created this revision.May 9 2022, 5:29 PM
Herald added a subscriber: mat. · View Herald TranscriptMay 9 2022, 5:29 PM
tcberner requested review of this revision.May 9 2022, 5:29 PM
Harbormaster completed remote builds in B45501: Diff 105785.May 9 2022, 5:29 PM
diizzy added a subscriber: diizzy.May 10 2022, 8:14 AM
diizzy added inline comments.
multimedia/avidemux/Makefile.common
151

If you want to avoid if loops you can also use this "trick"
https://cgit.freebsd.org/ports/tree/multimedia/ffmpeg/Makefile#n16

tcberner added inline comments.May 10 2022, 9:01 AM
multimedia/avidemux/Makefile.common
151

ah yes, will do.

lhersch_dssgmbh.de added a subscriber: lhersch_dssgmbh.de.Oct 3 2022, 11:10 AM
lhersch_dssgmbh.de added inline comments.
multimedia/avidemux-plugins/Makefile
33

This looks wrong, but it is correct and historically conditioned. PLUGIN_UI QT4 now stands for QT4 and QT5. Whether you actually want to build with QT4 or QT5 is determined by the switches ENABLE_QT5 (cmake/admCheckQt.cmake) and QT4 (cmake/admCheckQt4.cmake).

riggs added a subscriber: riggs.Oct 3 2022, 5:01 PM
riggs added inline comments.
multimedia/avidemux/Makefile.common
36

We have alsa (not in the kernel but libalsa for userspace compatibility), but it's probably fine to disable it unless it is required for some functionality.

Revision Contents
Changeset List

PathSize
multimedia/
avidemux-plugins/
10 lines
avidemux/
282 lines

Diff 105785

View Options

multimedia/avidemux-plugins/Makefile

Loading...
View Options

multimedia/avidemux/Makefile.common

Loading...