Page MenuHomeFreeBSD

multimedia/avidmux: modernize option handling
Needs ReviewPublic

Authored by tcberner on May 9 2022, 5:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 7, 1:59 AM
Unknown Object (File)
Thu, Mar 7, 1:46 AM
Unknown Object (File)
Thu, Mar 7, 12:19 AM
Unknown Object (File)
Dec 22 2023, 11:17 PM
Unknown Object (File)
Jun 21 2023, 1:53 PM
Unknown Object (File)
Jun 1 2023, 12:55 PM
Unknown Object (File)
Jun 1 2023, 12:40 PM
Unknown Object (File)
May 30 2023, 1:18 AM

Details

Reviewers
None
Group Reviewers
multimedia

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 45501
Build 42389: arc lint + arc unit

Event Timeline

diizzy added inline comments.
multimedia/avidemux/Makefile.common
151

If you want to avoid if loops you can also use this "trick"
https://cgit.freebsd.org/ports/tree/multimedia/ffmpeg/Makefile#n16

multimedia/avidemux/Makefile.common
151

ah yes, will do.

lhersch_dssgmbh.de added inline comments.
multimedia/avidemux-plugins/Makefile
33

This looks wrong, but it is correct and historically conditioned. PLUGIN_UI QT4 now stands for QT4 and QT5. Whether you actually want to build with QT4 or QT5 is determined by the switches ENABLE_QT5 (cmake/admCheckQt.cmake) and QT4 (cmake/admCheckQt4.cmake).

riggs added inline comments.
multimedia/avidemux/Makefile.common
36

We have alsa (not in the kernel but libalsa for userspace compatibility), but it's probably fine to disable it unless it is required for some functionality.