Page MenuHomeFreeBSD

drop dependency on autoconf213
Needs RevisionPublic

Authored by robert_openbsd.org on Mar 4 2022, 7:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 20 2023, 7:54 AM
Unknown Object (File)
Jun 29 2023, 7:00 PM
Unknown Object (File)
Jun 20 2023, 5:29 PM
Unknown Object (File)
Mar 5 2023, 5:31 PM
Unknown Object (File)
Feb 28 2023, 7:01 PM
Unknown Object (File)
Feb 21 2023, 8:20 AM
Unknown Object (File)
Feb 17 2023, 2:36 AM
Unknown Object (File)
Dec 14 2022, 3:35 AM
Subscribers

Details

Reviewers
cmt
Group Reviewers
gecko
Summary

The following patch removes autoconf213 as a dependency from firefox
and thunderbird beacause these m4 files are dumb.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

robert_openbsd.org created this revision.

Right, that's somewhat historic.
Any reason for this spring-cleaning right now?

This revision is now accepted and ready to land.Apr 5 2022, 6:30 PM

The horrors of run-autotools-fixup in bsd.port.mk led me here, no other reason, just seems like a sane thing to do.

Turns out this is not enough: the build fails with

Refreshing /wrkdirs/usr/ports/www/firefox/work/firefox-99.0/old-configure with /wrkdirs/usr/ports/www/firefox/work/firefox-99.0/build/autoconf/autoconf.sh
Autoconf requires GNU m4 1.1 or later
ERROR: autoconf exited with return code 1
===>  Script "configure" failed unexpectedly.

That's from ./build/moz.configure/old.configure

In D34445#788389, @cmt wrote:

Turns out this is not enough: the build fails with

Refreshing /wrkdirs/usr/ports/www/firefox/work/firefox-99.0/old-configure with /wrkdirs/usr/ports/www/firefox/work/firefox-99.0/build/autoconf/autoconf.sh
Autoconf requires GNU m4 1.1 or later
ERROR: autoconf exited with return code 1
===>  Script "configure" failed unexpectedly.

That's from ./build/moz.configure/old.configure

I haven't been able to reproduce that issues yet. Wonder why it is trying to refresh it.

cmt requested changes to this revision.Apr 6 2022, 6:51 PM

patch-bug847568 touches old-configure.in - I'd rather ask why it does not regenerate your old-configure (are you even building what I'm building?). If in doubt, avoid any manual manipulation of the source and use poudriere, everything else gives unpredictable results.

This revision now requires changes to proceed.Apr 6 2022, 6:51 PM
In D34445#788774, @cmt wrote:

patch-bug847568 touches old-configure.in - I'd rather ask why it does not regenerate your old-configure (are you even building what I'm building?). If in doubt, avoid any manual manipulation of the source and use poudriere, everything else gives unpredictable results.

Okay so the issue is that build/autoconf/autoconf.sh requires m4, and now that dependency is not being pulled in because there is no dependency on autoconf.