devel/cdash: Update to 2.2.3 and fix various issues

[grembo]

Summary

• Update to cdash 2.2.3
• Add missing dependencies
• Fix file ownership
• Rename config.local file so it won't overwrite user config on install
• Patch problem parsing xslt

Test Plan

poudriere
https://reviews.freebsd.org/P73

[grembo]

Not sure if using %%WWWOWN%% in the path name is a great idea (just realized this, was created using make makeplist).

[grembo]

Fix pkg-plist

[grembo]

Add missing dependency on php5-zlib

[bapt]

Does it pass poudriere tests?

[grembo]

Yes, please see link in "Test Plan"

[marino]

hi grembo,

this has been failing everywhere since you committed it:
http://portsmon.freebsd.org/portoverview.py?category=devel&portname=cdash

Can you take a look?

[grembo]

Will take a look.

[grembo]

I see what happened - the patch in question uses MSDOS CR-LF, it seems like those got stripped on commit. The easiest fix is probably to strip \r from all sources before patching.

Question: Is it possible to get on a blame list automatically in such cases? (I tested on poudriere and commited what worked and never noticed that it failed after commit).

[marino]

"The easiest fix is probably to strip \r from all sources before patching."

No, the proper fix is set "USES=dos2unix" and strip the file, then generate the patch after the stripping.

Grep the tree, there are many examples of this.

[marino]

oh, I see now you already did exactly that. good! :)

[grembo]

Yep, that did the trick.