Page MenuHomeFreeBSD

devel/wasm3: Fix compilation and clean up port
ClosedPublic

Authored by diizzy on Nov 7 2021, 7:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 1, 3:26 AM
Unknown Object (File)
Sun, Mar 31, 2:00 PM
Unknown Object (File)
Mar 15 2024, 11:07 AM
Unknown Object (File)
Feb 18 2024, 9:13 AM
Unknown Object (File)
Dec 20 2023, 8:31 AM
Unknown Object (File)
Dec 18 2023, 10:40 PM
Unknown Object (File)
Dec 9 2023, 12:42 PM
Unknown Object (File)
Dec 9 2023, 12:40 PM
Subscribers
None

Details

Summary

Disable -march=native as this overrides settings by the framework and fails on multiple non x86 platforms
Remove GitHub related variables that are already defined
Replace += with = for GH_TUPLE
Remove forced O3 optimization

References:
https://portsfallout.com/port/31163/
https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github-description
Example 21 "Use of USE_GITHUB with Multiple Distribution Files Using GH_TUPLE" in Porters Handbook
https://docs.freebsd.org/en/books/porters-handbook/book/#dads-cflags

Test Plan

Compile tested on FreeBSD 13.0-STABLE #1 stable/13-n247667-dc9094140c9 (amd64) (make, make check-plist)
Poudriere testport OK 12.2-RELEASE (amd64)
Poudriere testport OK 13.0-RELEASE (i386)

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

diizzy requested review of this revision.Nov 7 2021, 7:33 PM
diizzy created this revision.

I would split it into two commits

  1. COMMENT & pkg-descr
  2. build fix
This revision is now accepted and ready to land.Nov 7 2021, 7:39 PM

Sure, I'll wait on maintainer approval and/or timeout first.