Page MenuHomeFreeBSD

sendmail: do not use IN_CLASS macros
AbandonedPublic

Authored by karels on Oct 28 2021, 4:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 4 2024, 1:55 AM
Unknown Object (File)
Oct 3 2024, 2:12 PM
Unknown Object (File)
Oct 1 2024, 4:18 PM
Unknown Object (File)
Sep 26 2024, 1:09 PM
Unknown Object (File)
Sep 25 2024, 2:26 AM
Unknown Object (File)
Sep 5 2024, 8:49 AM
Unknown Object (File)
Aug 18 2024, 11:26 PM
Unknown Object (File)
Jul 28 2024, 11:10 PM
Subscribers

Details

Reviewers
gshapiro
Summary

sendmail was disecting addresses to see if they were on the loopback
"net". Instead, use IN_LOOPBACK(). This is more future-proof.

Test Plan

no functional change

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 42421
Build 39309: arc lint + arc unit

Event Timeline

If the current code works, I'd prefer to put this change in the upstream first and import it into the FreeBSD source on the next sendmail import. If this is causing breakage now, then we can proceed.

The current code works for now, but there is a proposal for a change that would make the old code fail. Note that IN_LOOPBACK() is not in Linux; not sure about other BSDs. The change could be conditional on #ifdef IN_LOOPBACK.

The change (with some minor tweaks) has been committed to the upstream open source distribution and will be part of the next vendor import into FreeBSD.

@karels: An associated release note entry was added, let me know if you would like the attribution modified:

Portability:
        Make use of IN_LOOPBACK, if defined, to determine if
        using a loopback address.  Patch from Mike Karels of
        FreeBSD.

Closing review, patch in progress upstream.