converters/fribidi: Update to 1.0.11
ClosedPublic
Actions

Authored by diizzy on Oct 13 2021, 8:51 PM.

Details

Reviewers

tcberner
arrowd
lbartoletti

Commits

R11:8f1b773597d3: converters/fribidi: Update to 1.0.11

Summary

PORTVERSION --> DISTVERSION
Enable OPTIMIZED_CFLAGS (-O3 from upstream), some tests are ~10% faster on my Intel I7-3770K CPU
Connect upstream's test suite to ports

PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=259156

Test Plan

Compile and tested on FreeBSD 13.0-STABLE #0 stable/13-n246086-a20c597c6d7 (amd64) (make, make check-plist, make test)
Poudriere testport OK 12.2-RELEASE (amd64)

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

diizzy requested review of this revision.Oct 13 2021, 8:51 PM

diizzy created this revision.

Intel I7-3770K CPU

Heh, I have exactly same CPU on my desktop machine.

This revision is now accepted and ready to land.Oct 14 2021, 9:56 AM

arrowd added inline comments.Oct 14 2021, 9:59 AM

converters/fribidi/files/patch-test_meson.build
9	This patch can be omitted if you put `lang/python3` into `TEST_DEPENDS`. This is generally wrong, but is acceptable in this particular case, I think.

diizzy added inline comments.Oct 14 2021, 10:12 AM

converters/fribidi/files/patch-test_meson.build
9	Fix submitted upstream https://github.com/fribidi/fribidi/pull/176 and `python:3.6+,test` should handle that as far as I can tell looking at https://cgit.freebsd.org/ports/tree/Mk/Uses/python.mk#n38

Closed by commit R11:8f1b773597d3: converters/fribidi: Update to 1.0.11 (authored by diizzy). · Explain WhyOct 14 2021, 10:23 AM

This revision was automatically updated to reflect the committed changes.

diizzy added a commit: R11:8f1b773597d3: converters/fribidi: Update to 1.0.11.

arrowd added inline comments.Oct 14 2021, 10:27 AM

converters/fribidi/files/patch-test_meson.build
9	Ah, this is meson code, not python -_\ Why doesn't it work for `'python3'`, then?

diizzy added inline comments.Oct 14 2021, 10:46 AM

converters/fribidi/files/patch-test_meson.build
9	It doesn't set/define BINARY_ALIAS as far as I can tell?

arrowd added inline comments.Oct 14 2021, 11:20 AM

converters/fribidi/files/patch-test_meson.build
9	The `import('python3')` clause invokes Meson's Python module, which should be able to find `python.X.Y` without `BINARY_ALIAS` or any other work from our side. This is how CMake's `find_package(Python)` works. So, if it doesn't, then this is a Meson bug.