Page MenuHomeFreeBSD

converters/fribidi: Update to 1.0.11
ClosedPublic

Authored by diizzy on Wed, Oct 13, 8:51 PM.

Details

Summary

PORTVERSION --> DISTVERSION
Enable OPTIMIZED_CFLAGS (-O3 from upstream), some tests are ~10% faster on my Intel I7-3770K CPU
Connect upstream's test suite to ports

PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=259156

Test Plan

Compile and tested on FreeBSD 13.0-STABLE #0 stable/13-n246086-a20c597c6d7 (amd64) (make, make check-plist, make test)
Poudriere testport OK 12.2-RELEASE (amd64)

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

diizzy created this revision.

Intel I7-3770K CPU

Heh, I have exactly same CPU on my desktop machine.

This revision is now accepted and ready to land.Thu, Oct 14, 9:56 AM
converters/fribidi/files/patch-test_meson.build
8

This patch can be omitted if you put lang/python3 into TEST_DEPENDS. This is generally wrong, but is acceptable in this particular case, I think.

converters/fribidi/files/patch-test_meson.build
8

Fix submitted upstream https://github.com/fribidi/fribidi/pull/176 and python:3.6+,test should handle that as far as I can tell looking at https://cgit.freebsd.org/ports/tree/Mk/Uses/python.mk#n38

This revision was automatically updated to reflect the committed changes.
converters/fribidi/files/patch-test_meson.build
8

Ah, this is meson code, not python -_\

Why doesn't it work for 'python3', then?

converters/fribidi/files/patch-test_meson.build
8

It doesn't set/define BINARY_ALIAS as far as I can tell?

converters/fribidi/files/patch-test_meson.build
8

The import('python3') clause invokes Meson's Python module, which should be able to find python.X.Y without BINARY_ALIAS or any other work from our side. This is how CMake's find_package(Python) works.

So, if it doesn't, then this is a Meson bug.

converters/fribidi/files/patch-test_meson.build
8

I think this covers your questions regarding meson and also references bug reports
https://github.com/open-source-parsers/jsoncpp/pull/1185