Only log dropped packets with IP options if log is enabled on rule
ClosedPublic
Actions

Authored by garga on Jul 27 2015, 7:46 PM.

Details

Reviewers

eri
gnn

Commits

rS286125: MFC r285945, r285960:
rS285945: Respect pf rule log option before log dropped packets with IP options or

Summary

Do not log all packets with IP otions set, respect rule's log option

Reference: https://redmine.pfsense.org/issues/4383

MFC after: 3 days

Obtained from: pfSense
Sponsored by: Netgate

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

garga updated this revision to Diff 7395.Jul 27 2015, 7:46 PM

garga retitled this revision from to Only log dropped packets with IP options if log is enabled on rule.

garga updated this object.

garga edited the test plan for this revision. (Show Details)

garga added reviewers: eri, gnn.

garga set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptJul 27 2015, 7:46 PM

garga updated this object.Jul 27 2015, 7:46 PM

Please mark with

Approved by: gnn

This revision is now accepted and ready to land.Jul 27 2015, 9:58 PM

Since i wrote it!

Closed by commit rS285945: Respect pf rule log option before log dropped packets with IP options or (authored by garga). · Explain WhyJul 28 2015, 10:31 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

netpfil/

pf/

pf.c

6 lines

Diff 7426

View Options

Only log dropped packets with IP options if log is enabled on ruleClosedPublicActions