Page MenuHomeFreeBSD

bsd.port.mk: fix QUIET flag
Needs RevisionPublic

Authored by rene on Jul 1 2014, 8:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jun 27, 8:43 PM
Unknown Object (File)
Dec 22 2023, 10:12 AM
Unknown Object (File)
Jul 3 2023, 1:23 PM
Unknown Object (File)
May 11 2023, 1:51 AM
Unknown Object (File)
Jul 1 2016, 12:09 PM
Unknown Object (File)
Mar 31 2016, 7:10 PM
Unknown Object (File)
Mar 4 2016, 3:06 AM
Unknown Object (File)
Jan 12 2016, 2:02 AM
Subscribers
None

Details

Reviewers
bapt
Group Reviewers
portmgr
Summary

the QUIET flag in bsd.port.mk is tested the wrong way around (line
2162), resulting in PATCH_SILENT=yes when not given and PATCH_SILENT being
undefined when given. This results in 'make makepatch' failing:

[: !=: unexpected operator

Plan: 'make makepatch' and 'make QUIET=yes makepatch' in www/chromium with
PORTVERSION/distinfo set to 36.0.1985.103 should error out on a non-applying
patch, but not on errors from bsd.port.mk

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

rene retitled this revision from to bsd.port.mk: fix QUIET flag.
rene updated this object.
rene added a reviewer: bapt.
bapt requested changes to this revision.Jul 1 2014, 8:37 PM
bapt edited edge metadata.

This result in this:

PATCH_SILENT=yes != "yes"

This revision now requires changes to proceed.Jul 1 2014, 8:37 PM