Page MenuHomeFreeBSD
Differential D32016

vmci: fix panic due to freeing unallocated resources
ClosedPublic
Actions

Authored by mp on Sep 18 2021, 8:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 6, 7:32 PM
Unknown Object (File)
Sun, Apr 5, 4:21 PM
Unknown Object (File)
Sat, Apr 4, 5:32 AM
Unknown Object (File)
Wed, Apr 1, 9:33 PM
Unknown Object (File)
Tue, Mar 31, 4:37 AM
Unknown Object (File)
Mon, Mar 30, 12:15 AM
Unknown Object (File)
Mon, Mar 23, 1:41 AM
Unknown Object (File)
Sun, Mar 22, 9:04 PM
View All Files
Subscribers
imp

Details

Reviewers
marcus
arrowd
Commits
rGb5d236785dc3: vmci: fix panic due to freeing unallocated resources
rG4e5c1be4202a: vmci: fix panic due to freeing unallocated resources
rG0f14bcbe3840: vmci: fix panic due to freeing unallocated resources
Summary

An error mapping PCI resources results in a panic due to unallocated
resources being freed up. This change puts the appropriate checks in
place to prevent the panic.

PR: 252445
Reported by: Marek Zarychta <zarychtam@plan-b.pwste.edu.pl>
Tested by: marcus
MFC after: 1 week
Sponsored by: VMware

Test Plan

Along with user testing, also simulated error by inserting a ENXIO
return in vmci_map_bars().

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
sys/
dev/
vmware/
vmci/
9 lines
3 lines
2 lines
48 lines
3 lines

Diff 96577

View Options

sys/dev/vmware/vmci/vmci.c

Loading...
View Options

sys/dev/vmware/vmci/vmci_event.c

Loading...
View Options

sys/dev/vmware/vmci/vmci_kernel_if.h

Loading...
View Options

sys/dev/vmware/vmci/vmci_kernel_if.c

Loading...
View Options

sys/dev/vmware/vmci/vmci_queue_pair.c

Loading...