graphics/sane-airscan: AirScan backend for SANE
ClosedPublic
Actions

Authored by diizzy on Sep 12 2021, 7:57 AM.

Details

Reviewers

tcberner
arrowd
lbartoletti

Commits

R11:f951db5cb274: graphics/sane-airscan: New port: AirScan backend for SANE

Summary

Changes to submitters patch (tested and approved):

sane-airscan update to latest release 0.99.26
Usage of "# $FreeBSD$" is deprecated (removed)
Removed incorrect dependencies: libepoll-shim, libsoup and gettext-runtime
Use non version specific shared lib when declaring libpng as dependency
Properly define libxml2 dependency
Make sure libsane-airscan.so is available
Disable usage of ctags during build
Convert pkg-message to UCL format

PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=245540

Test Plan

Compile tested on FreeBSD 13.0-STABLE #0 stable/13-n246086-a20c597c6d7 (amd64) (make, make check-plist)
Poudriere testport OK 11.4-RELEASE (amd64)
Poudriere testport OK 12.2-RELEASE (amd64)

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

diizzy requested review of this revision.Sep 12 2021, 7:57 AM

diizzy created this revision.

There's a bit noise from portlint and poudriere regarding the shared library but these are expected for SANE from what I've gathered.

[00:01:04] Portlint check
WARN: /vault2/poudriere/basefs/data/.m/122amd64-dev-default/ref/usr/ports/graphics/sane-airscan/pkg-plist: [4]: installing shared libraries, please define USE_LDCONFIG as appropriate
WARN: /vault2/poudriere/basefs/data/.m/122amd64-dev-default/ref/usr/ports/graphics/sane-airscan/pkg-message: possible use of absolute pathname "/etc/rc.conf(.local)...".
WARN: Consider to set DEVELOPER=yes in /etc/make.conf

====> Running Q/A tests (stage-qa)
Warning: /wrkdirs/usr/ports/graphics/sane-airscan/work/stage/usr/local/lib/sane/libsane-airscan.so.1 doesn't have a SONAME.
Warning: pkg(8) will not register it as being provided by the port.
Warning: If another port depend on it, pkg will not be able to know where it comes from.
Warning: It is in a subdirectory, it may not be used in another port.

diizzy edited the test plan for this revision. (Show Details)Sep 12 2021, 9:03 AM

arrowd added inline comments.Sep 12 2021, 10:33 AM

graphics/sane-airscan/Makefile
22	`MAKE_ENV` would fit more to hold these values.
29	Why create this symlink? I guess, this is the reason why `portlint` and `stage-qa` emit warnings for this file.

diizzy added inline comments.Sep 12 2021, 11:43 AM

graphics/sane-airscan/Makefile
22	Doesn't get picked up by upstreams Makefile resulting in a build failure
29	I added that because several other repos does this (for compatibility reasons as far as I could tell), removing it doesn't change the error message