Page MenuHomeFreeBSD

devel/py-pytest-cache integrate setuptools test command
ClosedPublic

Authored by loader on Jul 24 2015, 1:28 PM.

Details

Summary
  • added a patch for setup.py rather than running py.test directly.
  • removed build: target from regression-test:, the tests require installing the port.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

loader retitled this revision from to devel/py-pytest-cache integrate setuptools test command.
loader updated this object.
loader edited the test plan for this revision. (Show Details)
loader added a reviewer: koobs.

Has the setup.py patch been submitted in an issue upstream?

If not, that would be good.

If so, add breadcrumbs/comments with issue reference/link to the patch header

devel/py-pytest-cache/Makefile
28 ↗(On Diff #7261)

removed build: target from regression-test:, the tests require installing the port.

They shouldn't, and the tests should work post-build. I would especially expect this since pytest is a BUILD_DEPENDS when TESTS is enabled.

Having said that, pytest might be an interesting case since it uses itself to test itself.

Try to put 'build' back in, and test whether regression-test: works with the tests running in WRKSRC, as this is exactly how pytest/nose normally test a package.

koobs requested changes to this revision.Jul 27 2015, 3:44 AM
koobs edited edge metadata.
This revision now requires changes to proceed.Jul 27 2015, 3:44 AM
loader edited edge metadata.

add build: target back to regression-test:

koobs edited edge metadata.

LGTM

This revision is now accepted and ready to land.Jul 27 2015, 7:07 AM
In D3185#64445, @koobs wrote:

Has the setup.py patch been submitted in an issue upstream?

If not, that would be good.

If so, add breadcrumbs/comments with issue reference/link to the patch header

Not yet, I will try to submit it to upstream later today.

This revision was automatically updated to reflect the committed changes.